Skip to content

yang: Fix pyang errors in frr-bgp-types.yang - #20797

Merged
donaldsharp merged 1 commit into
FRRouting:masterfrom
y-bharath14:srib-yang-V9
Feb 13, 2026
Merged

yang: Fix pyang errors in frr-bgp-types.yang#20797
donaldsharp merged 1 commit into
FRRouting:masterfrom
y-bharath14:srib-yang-V9

Conversation

@y-bharath14

Copy link
Copy Markdown
Contributor

Fix pyang errors in frr-bgp-types.yang

frr-bgp-types.yang:40: error: RFC 8407: 4.8: statement "revision" must have a "reference" substatement
frr-bgp-types.yang:45: error: RFC 8407: 4.13,4.14: statement "typedef" must have a "description" substatement
frr-bgp-types.yang:49: error: RFC 8407: 4.13,4.14: statement "typedef" must have a "description" substatement
frr-bgp-types.yang:53: error: RFC 8407: 4.13,4.14: statement "typedef" must have a "description" substatement
frr-bgp-types.yang:57: error: RFC 8407: 4.13,4.14: statement "typedef" must have a "description" substatement
frr-bgp-types.yang:77: error: RFC 8407: 4.13,4.14: statement "typedef" must have a "description" substatement
frr-bgp-types.yang:97: error: RFC 8407: 4.13,4.14: statement "typedef" must have a "description" substatement
frr-bgp-types.yang:117: error: RFC 8407: 4.13,4.14: statement "typedef" must have a "description" substatement
frr-bgp-types.yang:137: error: RFC 8407: 4.13,4.14: statement "typedef" must have a "description" substatement

Fix pyang errors in frr-bgp-types.yang

Signed-off-by: y-bharath14 <y.bharath@samsung.com>
@greptile-apps

greptile-apps Bot commented Feb 12, 2026

Copy link
Copy Markdown

Greptile Overview

Greptile Summary

This PR fixes RFC 8407 compliance issues in yang/frr-bgp-types.yang by adding missing descriptions to all typedef statements and a reference to the revision statement. The changes address all 9 pyang errors listed in the PR description:

  • Added reference "FRRouting" to the revision statement
  • Added descriptions to 8 typedef statements: plist-ref, access-list-ref, as-path-filter-ref, bgp-instance-type, as-type, add-path-type, bfd-session-type, and direction

All descriptions are clear, concise, and accurately describe the purpose of each typedef. The changes are purely documentation-related and do not affect any functionality.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The changes are purely additive documentation improvements that add RFC 8407 compliance to the YANG model without modifying any functional code or data types
  • No files require special attention

Important Files Changed

Filename Overview
yang/frr-bgp-types.yang Added RFC 8407 compliant descriptions to all typedefs and reference to revision statement

@donaldsharp
donaldsharp merged commit 1f6b2c3 into FRRouting:master Feb 13, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants