Skip to content

debian: prefer libyang3 over libyang2 when building deb packages - #20871

Merged
mwinter-osr merged 1 commit into
FRRouting:masterfrom
Jafaral:libyang3
Feb 18, 2026
Merged

debian: prefer libyang3 over libyang2 when building deb packages#20871
mwinter-osr merged 1 commit into
FRRouting:masterfrom
Jafaral:libyang3

Conversation

@Jafaral

@Jafaral Jafaral commented Feb 18, 2026

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@FRRouting FRRouting deleted a comment from greptile-apps Bot Feb 18, 2026
@FRRouting FRRouting deleted a comment from greptile-apps Bot Feb 18, 2026
@Jafaral

Jafaral commented Feb 18, 2026

Copy link
Copy Markdown
Member Author

@greptile review

@Jafaral

Jafaral commented Feb 18, 2026

Copy link
Copy Markdown
Member Author

@Mergifyio backport dev/10.6

@mergify

mergify Bot commented Feb 18, 2026

Copy link
Copy Markdown

backport dev/10.6

βœ… Backports have been created

Details

@Jafaral Jafaral added this to the 10.6 milestone Feb 18, 2026
@greptile-apps

greptile-apps Bot commented Feb 18, 2026

Copy link
Copy Markdown

Greptile Summary

This PR swaps the order of the libyang alternative build dependencies in debian/control so that libyang-dev (>= 3.0.3) (libyang3) is preferred over libyang2-dev (>= 2.1.128) when building Debian packages. In Debian's dependency resolution, the first alternative in a | list is the preferred one.

  • Reorders libyang-dev (>= 3.0.3) | libyang2-dev (>= 2.1.128) to prefer libyang3, consistent with the project's direction toward libyang3 support
  • Fixes a minor spacing inconsistency: ( >= 3.0.3) is now (>= 3.0.3), matching the style used by all other version constraints in the file
  • Both versions remain supported as alternatives, so no backwards compatibility is broken
  • The configure.ac build system already supports both libyang2 and libyang3 via PKG_CHECK_MODULES([LIBYANG], [libyang >= 2.1.128])

Confidence Score: 5/5

  • This PR is safe to merge β€” it's a minimal, well-understood change to dependency ordering in Debian packaging metadata.
  • The change is a single-line reordering of alternative build dependencies with no functional risk. Both libyang2 and libyang3 remain supported. The change follows established Debian packaging conventions and is consistent with the project's existing build system support for both libyang versions.
  • No files require special attention.

Important Files Changed

Filename Overview
debian/control Swaps the order of libyang alternative build dependencies to prefer libyang3 (libyang-dev >= 3.0.3) over libyang2 (libyang2-dev >= 2.1.128). Also fixes a minor spacing inconsistency in the version constraint parentheses.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Debian Package Build] --> B{Resolve libyang\nbuild dependency}
    B -->|Before PR| C[Try libyang2-dev >= 2.1.128\nfirst]
    C -->|Not available| D[Fall back to\nlibyang-dev >= 3.0.3]
    B -->|After PR| E[Try libyang-dev >= 3.0.3\nfirst]
    E -->|Not available| F[Fall back to\nlibyang2-dev >= 2.1.128]
    C --> G[Build FRR]
    D --> G
    E --> G
    F --> G
Loading

Last reviewed commit: f054175

@mwinter-osr mwinter-osr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. sbuild prefers first option

@mwinter-osr
mwinter-osr merged commit cd612a3 into FRRouting:master Feb 18, 2026
20 checks passed
donaldsharp added a commit that referenced this pull request Feb 18, 2026
debian: prefer libyang3 over libyang2 when building deb packages (backport #20871)
@Jafaral
Jafaral deleted the libyang3 branch May 29, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants