tests: fix some python and test syntax - #20905
Merged
Merged
Conversation
Greptile SummaryFixes Python syntax warnings in test files by correcting escape sequences and replacing an unregistered pytest mark.
Note: The Confidence Score: 4/5
Important Files Changed
Last reviewed commit: 09cc79f |
| from lib.topolog import logger | ||
|
|
||
| pytestmark = pytest.mark.random_order(disabled=True) | ||
| pytestmark = pytest.mark.zebra |
There was a problem hiding this comment.
zebra marker is not registered in tests/topotests/pytest.ini. Add zebra: Tests that run against ZEBRA to the markers list (around line 63) to prevent warnings about unknown marks
Prompt To Fix With AI
This is a comment left during a code review.
Path: tests/topotests/zebra_multiple_connected/test_zebra_multiple_connected.py
Line: 24
Comment:
`zebra` marker is not registered in `tests/topotests/pytest.ini`. Add `zebra: Tests that run against ZEBRA` to the markers list (around line 63) to prevent warnings about unknown marks
How can I resolve this? If you propose a fix, please make it concise.Fix a couple of python escape syntax warnings, and an unknown pytest mark. Signed-off-by: Mark Stapp <mjs@cisco.com>
mjstapp
force-pushed
the
fix_topo_escape_dot
branch
from
February 23, 2026 17:48
09cc79f to
319955e
Compare
Contributor
Author
|
oof - quite right, no zebra test mark; removed it |
Jafaral
approved these changes
Feb 24, 2026
Member
|
@Mergifyio backport dev/10.6 |
β Backports have been createdDetails
|
donaldsharp
added a commit
that referenced
this pull request
Feb 24, 2026
tests: fix some python and test syntax (backport #20905)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a couple of python escape syntax warnings, and an unknown pytest mark - was seeing these reported in recent CI runs.