Always compare med fix - #20909
Merged
Merged
Conversation
The setup for adding routemaps was using `med` as a key value to add a metric. The bgp.py code in lib has no way to interpret this and as such the routes being choosen where `oldest path` since there was no metric to discriminate. Upon heavy load routes would be received in a unexpected order and the resulting nexthop would be unexpected. Fix this. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Med is not something that is recognizable by the create_route_maps functionality. Use metric instead since that is what is intended. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Greptile SummaryThis PR corrects a parameter naming issue in topotest route map configurations. The Additionally, in
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: ff9b005 |
Jafaral
approved these changes
Feb 24, 2026
Member
|
@Mergifyio backport dev/10.6 |
β Backports have been createdDetails
|
donaldsharp
added a commit
that referenced
this pull request
Feb 24, 2026
Always compare med fix (backport #20909)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
topotests have a
create_route_mapfunction which takes a dict of values, of which some tester has choosen to sendmeddown which means nothing. Switch it tometricas it should be.