🔴 Live TV: FRRouting/frr/pull/

hnattamaisub · 2026-02-24T04:00:49Z

New brief option for "show bgp neighbor" is added and logs are as below:

r1# show bgp neighbors 192.168.0.2 brief

Neighbor AS MsgRcvd MsgSent ResetTime State Afi/Safi PfxRcd PfxSnt
192.168.0.2 65000 22 22 00:00:57 Established IPv4 Unicast 7 8

r1#
r1# show bgp neighbors brief

Neighbor AS MsgRcvd MsgSent ResetTime State Afi/Safi PfxRcd PfxSnt
192.168.0.2 65000 85 85 00:04:06 Established IPv4 Unicast 7 8
192.168.101.2 65100 99 99 00:04:06 Established IPv4 Unicast 3 9

r1#
r1# show ip bgp neighbors brief

Neighbor AS MsgRcvd MsgSent ResetTime State Afi/Safi PfxRcd PfxSnt
192.168.0.2 65000 98 98 00:04:44 Established IPv4 Unicast 7 8
192.168.101.2 65100 112 112 00:04:44 Established IPv4 Unicast 3 9

r1# show ip bgp neighbors 192.168.0.2 brief

Neighbor AS MsgRcvd MsgSent ResetTime State Afi/Safi PfxRcd PfxSnt
192.168.0.2 65000 110 110 00:05:22 Established IPv4 Unicast 7 8

r1# show ip bgp neighbors 192.168.0.2 brief json
{
"192.168.0.2":{
"hostname":"r2",
"remoteAs":65000,
"localAs":65000,
"lastResetDueTo":"No path to specified Neighbor",
"bgpState":"Established",
"bgpTimerUpMsec":332000,
"bgpTimerUpString":"00:05:32",
"bgpTimerUpEstablishedEpoch":1771862507,
"lastResetTimerMsecs":343000,
"messageStats":{
"totalSent":117,
"totalRecv":117
},
"addressFamilyInfo":{
"ipv4Unicast":{
"acceptedPrefixCounter":7,
"sentPrefixCounter":8
}
}
}
}
r1# show bgp neighbors 192.168.0.2 brief json
{
"192.168.0.2":{
"hostname":"r2",
"remoteAs":65000,
"localAs":65000,
"lastResetDueTo":"No path to specified Neighbor",
"bgpState":"Established",
"bgpTimerUpMsec":348000,
"bgpTimerUpString":"00:05:48",
"bgpTimerUpEstablishedEpoch":1771862507,
"lastResetTimerMsecs":359000,
"messageStats":{
"totalSent":122,
"totalRecv":122
},
"addressFamilyInfo":{
"ipv4Unicast":{
"acceptedPrefixCounter":7,
"sentPrefixCounter":8
}
}
}
}
r1# show bgp neighbors brief json
{
"192.168.0.2":{
"hostname":"r2",
"remoteAs":65000,
"localAs":65000,
"lastResetDueTo":"No path to specified Neighbor",
"bgpState":"Established",
"bgpTimerUpMsec":363000,
"bgpTimerUpString":"00:06:03",
"bgpTimerUpEstablishedEpoch":1771862507,
"lastResetTimerMsecs":374000,
"messageStats":{
"totalSent":127,
"totalRecv":127
},
"addressFamilyInfo":{
"ipv4Unicast":{
"acceptedPrefixCounter":7,
"sentPrefixCounter":8
}
}
},
"192.168.101.2":{
"hostname":"r4",
"remoteAs":65100,
"localAs":65000,
"lastResetDueTo":"No path to specified Neighbor",
"bgpState":"Established",
"bgpTimerUpMsec":373000,
"bgpTimerUpString":"00:06:13",
"bgpTimerUpEstablishedEpoch":1771862497,
"lastResetTimerMsecs":374000,
"messageStats":{
"totalSent":141,
"totalRecv":141
},
"addressFamilyInfo":{
"ipv4Unicast":{
"acceptedPrefixCounter":3,
"sentPrefixCounter":9
}
}
}
}
r1# show ip bgp neighbors brief json
{
"192.168.0.2":{
"hostname":"r2",
"remoteAs":65000,
"localAs":65000,
"lastResetDueTo":"No path to specified Neighbor",
"bgpState":"Established",
"bgpTimerUpMsec":376000,
"bgpTimerUpString":"00:06:16",
"bgpTimerUpEstablishedEpoch":1771862507,
"lastResetTimerMsecs":387000,
"messageStats":{
"totalSent":132,
"totalRecv":132
},
"addressFamilyInfo":{
"ipv4Unicast":{
"acceptedPrefixCounter":7,
"sentPrefixCounter":8
}
}
},
"192.168.101.2":{
"hostname":"r4",
"remoteAs":65100,
"localAs":65000,
"lastResetDueTo":"No path to specified Neighbor",
"bgpState":"Established",
"bgpTimerUpMsec":386000,
"bgpTimerUpString":"00:06:26",
"bgpTimerUpEstablishedEpoch":1771862497,
"lastResetTimerMsecs":387000,
"messageStats":{
"totalSent":146,
"totalRecv":146
},
"addressFamilyInfo":{
"ipv4Unicast":{
"acceptedPrefixCounter":3,
"sentPrefixCounter":9
}
}
}
}
r1#

greptile-apps · 2026-02-24T04:04:28Z

Greptile Summary

This PR adds a brief option to the show bgp neighbors command, providing a compact tabular view of BGP neighbor information including AS, message counts, uptime, state, and per-AFI/SAFI prefix counts.

Key Changes:

Added VTY_BGP_PEER_SHOW_BRIEF_INFO flag to control brief output mode
Implemented brief output in both text (tabular) and JSON formats in bgp_show_peer()
Modified bgp_show_neighbor() to print header for brief text output
Updated command definition to accept brief keyword alongside existing graceful-restart option
Added comprehensive test coverage for single/multiple neighbors in text/JSON formats

Implementation Details:

Text format displays neighbors in a table with columns for neighbor IP, AS, message stats, reset time, state, and AFI/SAFI-specific prefix counts
Multiple AFI/SAFI families for a single neighbor are shown on separate rows with proper indentation
JSON format includes essential fields: hostname, AS numbers, state, uptime, message stats, and per-AFI/SAFI prefix counters
Early return in bgp_show_peer() ensures brief mode doesn't execute the full verbose output path

Confidence Score: 4/5

This PR is safe to merge with low risk of introducing bugs
The implementation is straightforward with proper separation between brief and full output modes. Code follows existing patterns in the codebase, handles both text and JSON output correctly, and includes comprehensive test coverage. Minor formatting alignment concern in multi-AFI/SAFI text output doesn't affect functionality.
No files require special attention

Important Files Changed

Filename	Overview
bgpd/bgp_vty.c	Adds brief output mode for BGP neighbors with text and JSON formats; implementation is solid with minor alignment concern in multi-AFI/SAFI text output
bgpd/bgp_vty.h	Adds VTY_BGP_PEER_SHOW_BRIEF_INFO flag and header constant; straightforward changes with no issues
tests/topotests/bgp_features/test_bgp_features.py	Adds comprehensive test coverage for brief mode in both text and JSON formats; validates all required fields and scenarios

_{Last reviewed commit: 407137c}

donaldsharp · 2026-02-24T12:50:52Z

doc changes?

hnattamaisub · 2026-02-25T11:40:01Z

ci:rerun

ton31337

Documentation is missing.

hnattamaisub · 2026-02-26T04:27:41Z

doc changes?

done

hnattamaisub · 2026-02-26T04:27:48Z

Documentation is missing.

done

hnattamaisub · 2026-02-26T12:59:42Z

ci:rerun

ton31337

Still some comments from my side...

riw777

looks good, waiting on @ton31337 's comment

hnattamaisub · 2026-03-04T05:07:37Z

ci:rerun

hnattamaisub · 2026-03-05T13:02:49Z

ci:rerun

ashred-lnx · 2026-03-05T22:26:28Z

Hi @riw777 @ton31337 can we please merge this? thanks

ton31337

Please use f-strings everywhere including logger.

hnattamaisub · 2026-03-06T08:04:12Z

Please use f-strings everywhere including logger.

done , thanks

hnattamaisub · 2026-03-06T15:20:43Z

ci:rerun

hnattamaisub · 2026-03-09T10:20:11Z

ci:rerun

New commands: 1)show bgp neighbors 192.168.0.2 brief 2)show bgp neighbors brief 3)show ip bgp neighbors brief 4)show ip bgp neighbors 192.168.0.2 brief 5)show ip bgp neighbors 192.168.0.2 brief json 6)show bgp neighbors 192.168.0.2 brief json 7)show bgp neighbors brief json 8)show ip bgp neighbors brief json Signed-off-by: harini <hnattamaisub@nvidia.com>

Signed-off-by: harini <hnattamaisub@nvidia.com>

ton31337

LGTM

hnattamaisub · 2026-03-10T03:42:51Z

ci:rerun

frrbot Bot added bgp tests Topotests, make check, etc labels Feb 24, 2026

github-actions Bot added size/L master labels Feb 24, 2026

hnattamaisub force-pushed the bgp_brief_json branch 5 times, most recently from d2305a7 to 7912ab5 Compare February 24, 2026 06:05

ton31337 requested changes Feb 25, 2026

View reviewed changes

Comment thread bgpd/bgp_vty.c Outdated

Comment thread bgpd/bgp_vty.c Outdated

frrbot Bot added the documentation label Feb 26, 2026

github-actions Bot added the rebase PR needs rebase label Feb 26, 2026

hnattamaisub force-pushed the bgp_brief_json branch from 08ab264 to 8b93db9 Compare February 26, 2026 04:25

ton31337 approved these changes Feb 27, 2026

View reviewed changes

ton31337 reviewed Mar 2, 2026

View reviewed changes

Comment thread bgpd/bgp_vty.c Outdated

ton31337 requested changes Mar 2, 2026

View reviewed changes

Comment thread bgpd/bgp_vty.c Outdated

hnattamaisub force-pushed the bgp_brief_json branch from 8b93db9 to f84f78e Compare March 3, 2026 13:06

ton31337 reviewed Mar 3, 2026

View reviewed changes

Comment thread doc/user/bgp.rst Outdated

Comment thread tests/topotests/bgp_features/test_bgp_features.py Outdated

Comment thread tests/topotests/bgp_features/test_bgp_features.py Outdated

riw777 approved these changes Mar 3, 2026

View reviewed changes

hnattamaisub force-pushed the bgp_brief_json branch 3 times, most recently from db79c59 to ab6cdc2 Compare March 5, 2026 03:49

ton31337 reviewed Mar 6, 2026

View reviewed changes

hnattamaisub force-pushed the bgp_brief_json branch from ab6cdc2 to 7e60412 Compare March 6, 2026 07:57

hnattamaisub force-pushed the bgp_brief_json branch from 7e60412 to c4f14a1 Compare March 9, 2026 14:17

ton31337 reviewed Mar 9, 2026

View reviewed changes

Comment thread tests/topotests/bgp_features/test_bgp_features.py Outdated

hnattamaisub added 2 commits March 9, 2026 08:28

tests: add topotest for show bgp neighbors brief

bf528fd

Signed-off-by: harini <hnattamaisub@nvidia.com>

doc: add documentation for 'show bgp neigbor brief' command

509fe96

Signed-off-by: harini <hnattamaisub@nvidia.com>

hnattamaisub force-pushed the bgp_brief_json branch from c4f14a1 to 509fe96 Compare March 9, 2026 15:29

ton31337 approved these changes Mar 9, 2026

View reviewed changes

ton31337 merged commit d6671d4 into FRRouting:master Mar 10, 2026
19 checks passed

hnattamaisub deleted the bgp_brief_json branch March 10, 2026 10:45

Uh oh!

Conversation

hnattamaisub commented Feb 24, 2026

Uh oh!

greptile-apps Bot commented Feb 24, 2026

Greptile Summary

Confidence Score: 4/5

Important Files Changed

Uh oh!

donaldsharp commented Feb 24, 2026

Uh oh!

hnattamaisub commented Feb 25, 2026

Uh oh!

ton31337 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hnattamaisub commented Feb 26, 2026

Uh oh!

hnattamaisub commented Feb 26, 2026

Uh oh!

hnattamaisub commented Feb 26, 2026

Uh oh!

Uh oh!

ton31337 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

riw777 left a comment

Choose a reason for hiding this comment

Uh oh!

hnattamaisub commented Mar 4, 2026

Uh oh!

hnattamaisub commented Mar 5, 2026

Uh oh!

ashred-lnx commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ton31337 left a comment

Choose a reason for hiding this comment

Uh oh!

hnattamaisub commented Mar 6, 2026

Uh oh!

hnattamaisub commented Mar 6, 2026

Uh oh!

hnattamaisub commented Mar 9, 2026

Uh oh!

Uh oh!

ton31337 left a comment

Choose a reason for hiding this comment

Uh oh!

hnattamaisub commented Mar 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ashred-lnx commented Mar 5, 2026 •

edited

Loading