Skip to content

yang: Revision statements are not given in reverse chronological order at frr-staticd.yang - #20921

Merged
riw777 merged 1 commit into
FRRouting:masterfrom
y-bharath14:srib-yang-V11
Feb 24, 2026
Merged

yang: Revision statements are not given in reverse chronological order at frr-staticd.yang#20921
riw777 merged 1 commit into
FRRouting:masterfrom
y-bharath14:srib-yang-V11

Conversation

@y-bharath14

Copy link
Copy Markdown
Contributor

Revision statements are not given in reverse chronological order at frr-staticd.yang

frr-staticd.yang:72: warning: the revision statements are not given in reverse chronological order
frr-staticd.yang:226: error: RFC 8407: 4.14: statement "augment" must have a "description" substatement

…r at frr-staticd.yang

Revision stements are not given in reverse chronological order at frr-staticd.yang

Signed-off-by: y-bharath14 <y.bharath@samsung.com>
@greptile-apps

greptile-apps Bot commented Feb 24, 2026

Copy link
Copy Markdown

Greptile Summary

Corrects YANG module compliance issues by reordering revision statements in reverse chronological order and adding a required description to an augment statement.

  • Swapped revision dates so 2026-01-23 appears before 2019-12-03 (RFC 7950 requirement)
  • Added description to the weight augment statement (RFC 8407 section 4.14 requirement)
  • Added newline at end of file for proper formatting

These changes resolve the reported warnings and errors from YANG validation tools.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The changes are minimal, well-targeted, and only address YANG schema compliance issues without altering any functional behavior. Both fixes correctly implement RFC requirements for YANG modules.
  • No files require special attention

Important Files Changed

Filename Overview
yang/frr-staticd.yang Fixed revision chronological order and added missing augment description per RFC 8407 requirements

Last reviewed commit: b8f81a1

@riw777 riw777 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777
riw777 merged commit b65371b into FRRouting:master Feb 24, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants