bgpd,lib,zebra: use explicit casts in tracepoint definitions

[mjstapp]

gcc 14 doesn't like some of the implicit casting in the tracepoint macros: cast pointers in tracepoint arguments to intptr_t explicitly to keep compilers happy. Also fix a bug in a bgp tracepoint.

[greptile-apps]

Greptile Summary

This PR adds explicit (intptr_t) casts to tracepoint macro arguments across bgpd, lib, and zebra to silence GCC 14 warnings about implicit pointer-to-integer conversions. It also fixes a real bug in bgpd/bgp_trace.h where eth_tag was passed as a pointer (&pfx->prefix.macip_addr.eth_tag) instead of a value (pfx->prefix.macip_addr.eth_tag) to ctf_integer.

Key changes:

• bgpd/bgp_trace.h: Explicit cast for attr pointer in process_update; bug fix removing the erroneous & from eth_tag in evpn_mac_ip_zsend — without this fix the tracepoint would log the field's memory address as the EVPN ethernet tag instead of its actual value.
• lib/libfrr_trace.h: All void * / struct-pointer arguments in hash, memory, list, route-table, and thread-scheduler tracepoints cast explicitly. The struct event ** dereference uses the idiomatic two-step (intptr_t)(void*) cast, which is correct per C standard aliasing rules.
• zebra/zebra_trace.h: Pointer arguments for netlink command and Netlink message header tracepoints cast explicitly across eight repetitive tracepoint definitions.

Confidence Score: 5/5

Safe to merge — all changes are mechanical explicit casts plus one genuine bug fix in a tracepoint.

All modifications are straightforward pointer-to-intptr_t casts required by GCC 14's stricter implicit-conversion rules. The only behavioral change is the eth_tag bug fix in bgpd/bgp_trace.h, which is clearly correct (removing the erroneous address-of operator). No logic paths, data structures, or protocol handling are affected — tracepoints are no-ops unless LTTng is enabled. No remaining P0/P1 issues.

No files require special attention.

Important Files Changed

Filename	Overview
bgpd/bgp_trace.h	Two fixes: explicit (intptr_t) cast for attr pointer, and a genuine bug fix removing the erroneous address-of operator from the eth_tag field in evpn_mac_ip_zsend.
lib/libfrr_trace.h	All pointer-to-integer tracepoint arguments wrapped in explicit (intptr_t) casts; struct event ** dereference cast via (intptr_t)(void*) to comply with C aliasing rules.
zebra/zebra_trace.h	All header and netlink_cmd struct-pointer arguments cast explicitly to intptr_t across eight repetitive tracepoint definitions.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Tracepoint macro invoked\ne.g. ctf_integer_hex] --> B{Argument type}
    B -->|void* / struct ptr| C["Before: implicit ptr→intptr_t\n⚠ GCC 14 warning"]
    B -->|void* / struct ptr| D["After: explicit (intptr_t) cast\n✅ No warning"]
    B -->|struct event **| E["After: (intptr_t)(void*)(*thread_ptr)\n✅ Correct aliasing"]
    B -->|uint32_t field eth_tag bug| F["Before: &field (address)\n🐛 Wrong value logged"]
    F --> G["After: field (value)\n✅ Correct eth_tag logged"]
    D --> H[LTTng tracepoint recorded]
    E --> H
    G --> H

Loading

_{Reviews (1): Last reviewed commit: "bgpd,lib,zebra: cast pointers to intptr_..." | Re-trigger Greptile}

[mjstapp]

fixed a checkpatch warning

[riw777]

looks good