zebra: fix wrong hash count function call

[rzalamena]

The Pull Requests #21263 and #21388 had conflicting changes:

• 21263 uses hashcount (lib/hash.h implementation) to count items in a hash
• 21388 changes the hash type being referenced in the other PR with type safe hash (lib/typesafe.h)

Since both Pull Requests got merged at nearly the same time the CI didn't have a chance to build them together.

[greptile-apps]

Greptile Summary

This PR fixes a merge conflict between #21263 (which added hashcount() calls to count EVPN neighbor entries) and #21388 (which converted nh_table from struct hash * to a typesafe hash zebra_neigh_db_head). The fix correctly replaces hashcount(zl3vni->nh_table) with zebra_neigh_db_count(zl3vni->nh_table) throughout zebra_vxlan.c, while leaving hashcount(zl3vni->rmac_table) intact since rmac_table remains a plain struct hash *.

Confidence Score: 5/5

Safe to merge — targeted, correct bug fix with no side effects.

Single-file change that replaces hashcount() with the correct typesafe zebra_neigh_db_count() for nh_table, which was converted to a typesafe hash by PR #21388. rmac_table (a plain struct hash *) correctly retains hashcount(). No logic errors, no missing cases, and no P1/P0 findings.

No files require special attention.

Important Files Changed

Filename	Overview
zebra/zebra_vxlan.c	Replaces incorrect hashcount(zl3vni->nh_table) calls with zebra_neigh_db_count(zl3vni->nh_table) to match the typesafe hash type introduced by PR #21388; rmac_table (still struct hash *) correctly retains hashcount().

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[zebra_l3vni struct] --> B["rmac_table\n(struct hash *)"]
    A --> C["nh_table\n(zebra_neigh_db_head — typesafe)"]

    B --> D["hashcount(rmac_table)\n✅ correct for struct hash *"]
    C --> E["hashcount(nh_table)\n❌ BEFORE — wrong type"]
    C --> F["zebra_neigh_db_count(nh_table)\n✅ AFTER — correct for typesafe hash"]

    style E fill:#ffcccc,stroke:#cc0000
    style F fill:#ccffcc,stroke:#00cc00
    style D fill:#ccffcc,stroke:#00cc00

Loading

_{Reviews (1): Last reviewed commit: "zebra: fix wrong hash count function cal..." | Re-trigger Greptile}