Coverity cleanup some more items found

[donaldsharp]

No description provided.

[greptile-apps]

Greptile Summary

This PR cleans up Coverity static analysis warnings across three files: removes dead json_flags cleanup code in bgp_evpn_vty.c (the variable is only allocated in the if (add_prefix_to_json) branch, making the else-branch free unreachable), refactors BGP-LS NLRI encoding functions in bgp_ls_nlri.c to track written bytes via stream position delta (stream_get_endp(s) - start) instead of an accumulated written counter, and fixes non-standard %Lx/%Lu format specifiers to portable PRIx64/PRIu64 in mgmt_vty_frontend.c.

Confidence Score: 5/5

Safe to merge — all three changes are correct Coverity cleanups with no functional regressions

The bgp_evpn_vty.c change correctly removes dead code (json_flags is only allocated where add_prefix_to_json is true, so the else-branch free was unreachable). The bgp_ls_nlri.c refactor to stream position delta is functionally equivalent to the old accumulated counter. The mgmt_vty_frontend.c format-specifier fix is a correctness improvement. No P0/P1 issues found.

No files require special attention

Important Files Changed

Filename	Overview
bgpd/bgp_evpn_vty.c	Removes dead json_flags free/null code in the else branch — json_flags is only ever allocated in the if (add_prefix_to_json) branch, so it is always NULL when the else branch is reached
bgpd/bgp_ls_nlri.c	Replaces accumulated written counter with stream_get_endp(s) - start for return values across all encode functions; functionally equivalent and cleaner; minor implicit size_t to int narrowing on return is benign given BGP message size bounds
mgmtd/mgmt_vty_frontend.c	Replaces non-standard %Lx/%Lu format specifiers with portable PRIx64/PRIu64 — correct fix for 64-bit integer formatting

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["bgp_ls_encode_nlri(s, nlri)"] --> B{Validate nlri}
    B -- invalid --> ERR[return -1]
    B -- valid --> C["start = stream_get_endp(s)"]
    C --> D["Write NLRI type + length placeholder"]
    D --> E["value_start = stream_get_endp(s)"]
    E --> F{nlri_type switch}
    F -- NODE --> G["bgp_ls_encode_node_nlri()"]
    F -- LINK --> H["bgp_ls_encode_link_nlri()"]
    F -- IPV4/IPV6_PREFIX --> I["bgp_ls_encode_prefix_nlri()"]
    F -- RESERVED --> ERR
    G & H & I -- ret < 0 --> ERR
    G & H & I -- ret >= 0 --> J["stream_putw_at(s, len_pos, endp - value_start)"]
    J --> K["return stream_get_endp(s) - start"]

Loading

_{Reviews (1): Last reviewed commit: "bgpd: Let the stream track how much was ..." | Re-trigger Greptile}