ospfd: remove unnecessary space

[anlancs]

Remove unnecessary spaces in config written with interface_config_auth_str().

Before:

interface enp1s0
 ip ospf authentication  1.2.3.4

After:

interface enp1s0
 ip ospf authentication 1.2.3.4

Also, remove trailing one from "area <> virtual-link <> authentication" in this same way.

[greptile-apps]

Greptile Summary

This PR removes a spurious trailing space in interface_config_auth_str() that was emitted when OSPF simple authentication is configured. The fix applies to both the ip ospf authentication interface config and the area <> virtual-link <> authentication config paths.

• Root cause: OSPF_AUTH_SIMPLE wrote \" \" into the suffix buffer; since the caller's format string already ends with authentication, this produced a stale trailing space. Setting buf[0] = '\\0' instead yields the correct output.
• Scope: Single switch-case change in one helper function; both callers guard buf usage behind if (ret), so the empty-string value is safe in all code paths.

Confidence Score: 5/5

Safe to merge — the change is a targeted one-line cosmetic fix with no functional side effects.

The fix is minimal and well-scoped: it corrects trailing whitespace in generated OSPF config for simple authentication. Both call sites guard on the return value before using the buffer, so the empty string is handled correctly. No logic is altered beyond the formatting of the emitted config line.

No files require special attention.

Important Files Changed

Filename	Overview
ospfd/ospf_vty.c	One-line fix in interface_config_auth_str(): replaces snprintf(buf, BUFSIZ, " ") with buf[0] = '\0' for OSPF_AUTH_SIMPLE, eliminating the extra space in generated config output.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[interface_config_auth_str] --> B{params->auth_type}
    B -->|OSPF_AUTH_NOTSET| C[return 0]
    B -->|OSPF_AUTH_NULL| D["buf = ' null'\nreturn 1"]
    B -->|OSPF_AUTH_SIMPLE| E["buf = '' ✅\nreturn 1"]
    B -->|OSPF_AUTH_CRYPTOGRAPHIC| F["buf = ' message-digest'\nor ' key-chain NAME'\nreturn 1"]
    D --> G[Caller: 'ip ospf authentication null']
    E --> H[Caller: 'ip ospf authentication']
    F --> I[Caller: 'ip ospf authentication message-digest']

Loading

_{Reviews (1): Last reviewed commit: "ospfd: remove unnecessary space" | Re-trigger Greptile}

[donaldsharp]

I'll work on getting this through CI, LGTM

[ton31337]

@Mergifyio backport stable/10.6 stable/10.5 stable/10.4 stable/10.3 stable/10.2

[mergify]

backport stable/10.6 stable/10.5 stable/10.4 stable/10.3 stable/10.2

✅ Backports have been created

Details

• #21993 ospfd: remove unnecessary space (backport #21979) has been created for branch stable/10.6
• #21994 ospfd: remove unnecessary space (backport #21979) has been created for branch stable/10.5
• #21995 ospfd: remove unnecessary space (backport #21979) has been created for branch stable/10.4
• #21996 ospfd: remove unnecessary space (backport #21979) has been created for branch stable/10.3
• #21997 ospfd: remove unnecessary space (backport #21979) has been created for branch stable/10.2

[riw777]

looks good