Skip to content

yang: inet type mismatch in frr-bfdd.yang - #22241

Merged
donaldsharp merged 1 commit into
FRRouting:masterfrom
y-bharath14:srib-yang-Ver16
Jun 8, 2026
Merged

yang: inet type mismatch in frr-bfdd.yang#22241
donaldsharp merged 1 commit into
FRRouting:masterfrom
y-bharath14:srib-yang-Ver16

Conversation

@y-bharath14

Copy link
Copy Markdown
Contributor

inet type mismatch in frr-bfdd.yang

inet type mismatch in frr-bfdd.yang

Signed-off-by: y-bharath14 <y.bharath@samsung.com>
@greptile-apps

greptile-apps Bot commented Jun 8, 2026

Copy link
Copy Markdown

Greptile Summary

This PR fixes two issues in yang/frr-bfdd.yang: a copy-paste error in a description string and a type mismatch for an SRv6 source address leaf.

  • The remote-diagnostic leaf's description was incorrectly labelled "Local session diagnostic" β€” changed to "Remote session diagnostic" to match its name and context in the "Remote settings" block.
  • The srv6-source-ipv6 leaf was typed as inet:ip-address (which permits IPv4 and IPv6), corrected to inet:ipv6-address to match the leaf name, its description ("source ipv6 address"), and the sibling srv6-encap-data leaf-list which already uses inet:ipv6-address.

Confidence Score: 5/5

Both changes are small, targeted corrections with no risk of regressions β€” safe to merge.

The type change from inet:ip-address to inet:ipv6-address is consistent with the leaf name, description, and the sibling srv6-encap-data leaf-list. The description fix is a straightforward copy-paste correction. Neither change affects runtime behavior of existing valid configurations.

No files require special attention.

Important Files Changed

Filename Overview
yang/frr-bfdd.yang Two fixes: corrects the description for remote-diagnostic from "Local" to "Remote", and tightens srv6-source-ipv6 type from inet:ip-address to inet:ipv6-address to match the leaf's name and SRv6's IPv6-only nature.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["frr-bfdd.yang YANG model"] --> B["BFD session state group"]
    A --> C["BFD session configuration"]
    B --> D["remote-diagnostic leaf\ntype: diagnostic\ndescription: βœ… 'Remote session diagnostic'\n(was: 'Local session diagnostic')"]
    C --> E["srv6-source-ipv6 leaf\ntype: βœ… inet:ipv6-address\n(was: inet:ip-address)"]
    C --> F["srv6-encap-data leaf-list\ntype: inet:ipv6-address (unchanged)"]
    E -- "now consistent with" --> F
Loading

Reviews (1): Last reviewed commit: "yang: inet type mismatch in frr-bfdd.yan..." | Re-trigger Greptile

@donaldsharp

Copy link
Copy Markdown
Member

@Mergifyio backport stable/10.6 stable/10.5

@donaldsharp
donaldsharp merged commit 61c6201 into FRRouting:master Jun 8, 2026
25 checks passed
@mergify

mergify Bot commented Jun 8, 2026

Copy link
Copy Markdown

backport stable/10.6 stable/10.5

βœ… Backports have been created

Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants