[Android 14 Beta3] Can't control the device screen #4074

Activity

1. DerekWuYD commented on Jun 9, 2023

   

   DerekWuYD

   on Jun 9, 2023

   ContributorAuthor

   More actions

   This method works both on Android 14 Beta3 and pervious version.

   Test result :

   scrcpy 2.0 <https://github.com/Genymobile/scrcpy>
   x/server/scrcpy-server: 1 file pushed, 0 skipped. 133.6 MB/s (53187 bytes in 0.000s)
   [server] INFO: Device: Google Pixel 7 Pro (Android 14)
   [server] INFO: Using the InputManagerGlobal API
   INFO: Renderer: opengl
   INFO: OpenGL version: 4.5 (Compatibility Profile) Mesa 22.3.3
   ...
   
2. rom1v

   added a commit that references this issue on Jun 9, 2023

   Add InputManagerGlobal for Android 14 beta 3

   ...

   This issue will close once commit 03a8a71 is merged into the 'master' branch.

   03a8a71
3. rom1v commented on Jun 10, 2023

   

   rom1v

   on Jun 10, 2023

   Collaborator

   More actions

   Thank you again for the fix.

   However, I don't really understand the stacktrace:

   Caused by: java.lang.reflect.InvocationTargetException
   	at java.lang.reflect.Method.invoke(Native Method)
   	at com.genymobile.scrcpy.wrappers.ServiceManager.getInputManager(ServiceManager.java:69)
   	... 8 more
   Caused by: java.lang.NullPointerException
   	at java.util.Objects.requireNonNull(Objects.java:207)
   	at android.hardware.input.InputManager.getInstance(InputManager.java:271)
   	... 10 more
   

   Since you get an InvocationTargetException, the invocation fails (getInstanceMethod.invoke(null);), so getInstanceMethod != null, so the method InputManager.getInstance() still exists (?), but does not accept a null target (so it is not static anymore?).

   Could you please post your framework.jar so that I can understand?

   adb pull /system/framework/framework.jar
   

   👍React with 👍1Reacted by For Fork Sake
4. forforksake commented on Jun 11, 2023

   

   forforksake

   on Jun 11, 2023

   Last edited by forforksake

   More actions

   Could you please post your framework.jar so that I can understand?

   adb pull /system/framework/framework.jar
   

   Thanks to you both!

   I was having the exact same issue on Android 14 beta 3, on Pixel 6 Pro via Kubuntu 23.04

   framework.jar from my device =
   framework.tar.gz
5. forforksake commented on Jun 11, 2023

   

   forforksake

   on Jun 11, 2023

   More actions

   This method works both on Android 14 Beta3 and pervious version.

   Test result :

   scrcpy 2.0 <https://github.com/Genymobile/scrcpy>
   x/server/scrcpy-server: 1 file pushed, 0 skipped. 133.6 MB/s (53187 bytes in 0.000s)
   [server] INFO: Device: Google Pixel 7 Pro (Android 14)
   [server] INFO: Using the InputManagerGlobal API
   INFO: Renderer: opengl
   INFO: OpenGL version: 4.5 (Compatibility Profile) Mesa 22.3.3
   ...
   

   Works perfectly - saved my life man, just smashed my screen and to my horror when I loaded scrcpy for the first time on A14 - disaster! Thanks both
6. DerekWuYD commented on Jun 12, 2023

   

   DerekWuYD

   on Jun 12, 2023

   ContributorAuthor

   More actions

   #4074 (comment)

   Actually android.hardware.input.InputManager.getInstance still exist, but there's some changes in the function body.
   Let's figure out the best solution when Android 14 source code release on AOSP : )
7. rom1v commented on Jun 12, 2023

   

   rom1v

   on Jun 12, 2023

   Collaborator

   More actions

   framework.jar from my device =
   framework.tar.gz

   Thank you 👍

   So in Android 13 (current AOSP master), here is the implementation of InputManager.getInstance():

       @UnsupportedAppUsage
       public static InputManager getInstance() {
           synchronized (InputManager.class) {
               if (sInstance == null) {
                   try {
                       sInstance = new InputManager(IInputManager.Stub
                               .asInterface(ServiceManager.getServiceOrThrow(Context.INPUT_SERVICE)));
                   } catch (ServiceNotFoundException e) {
                       throw new IllegalStateException(e);
                   }
               }
               return sInstance;
           }
       }

   In Android 14 (the version from your framework.jar), the new InputManager.getInstance() implementation is:

       @Deprecated
       public static InputManager getInstance() {
           return (InputManager) ((Application) Objects.requireNonNull(ActivityThread.currentApplication())).getSystemService(InputManager.class);
       }

   And InputManagerGlobal.getInstance():

       public static InputManagerGlobal getInstance() {
           InputManagerGlobal inputManagerGlobal;
           IBinder b;
           synchronized (InputManagerGlobal.class) {
               if (sInstance == null && (b = ServiceManager.getService("input")) != null) {
                   sInstance = new InputManagerGlobal(IInputManager.Stub.asInterface(b));
               }
               inputManagerGlobal = sInstance;
           }
           return inputManagerGlobal;
       }

   👍React with 👍2Reacted by Derek Wu and For Fork Sake
8. rom1v

   added a commit that references this issue on Jun 12, 2023

   Add InputManagerGlobal for Android 14 beta 3

   ...

   This issue will close once commit 34adddc is merged into the 'master' branch.

   34adddc
9. icantremember commented on Jun 13, 2023

   

   icantremember

   on Jun 13, 2023

   Last edited by icantremember

   More actions

   Works perfectly - saved my life man, just smashed my screen and to my horror when I loaded scrcpy for the first time on A14 - disaster! Thanks both

   Sorry if I'm not following, but what "Works perfectly"? Am I just not seeing a command line switch that has options allowing this to work?

   Thanks.
10. rom1v commented on Jun 13, 2023

    

    rom1v

    on Jun 13, 2023

    Collaborator

    More actions

    @icantremember #4075
11. rom1v

    added a commit that references this issue on Jun 13, 2023

    Add InputManagerGlobal for Android 14 beta 3

    ...

    This issue will close once commit 5bd7514 is merged into the 'master' branch.

    5bd7514
12. icantremember commented on Jun 13, 2023

    

    icantremember

    on Jun 13, 2023

    More actions

    Thanks for the reply, but I think I'm in a bit over my head. That commit would only help me if I were to build from source on my own, right? There's no (pre)release that has it yet, right?
13. rom1v commented on Jun 13, 2023

    

    rom1v

    on Jun 13, 2023

    Last edited by rom1v

    Collaborator

    More actions

    That commit would only help me if I were to build from source on my own, right? There's no (pre)release that has it yet, right?

    That's correct.

    But I plan to release a new version soon (v2.1, maybe next week), which is basically what is on dev branch, currently on commit 5bd7514 (+ the future SDL 2.28 not released yet). So if you beta-test it and report regressions/problems, I can provide a build 😄

    Here it is:

    • scrcpy-win64-pr4075.zip SHA-256: acd8b948663722ea19af623b35c5527954e29805ef127f905016689abe289462

    (check git log for new features and command line options)
14. icantremember commented on Jun 13, 2023

    

    icantremember

    on Jun 13, 2023

    More actions

    But I plan to release a new version soon (v2.1, maybe next week), which is basically what is on dev branch, currently on commit 5bd7514 (+ the future SDL 2.28 not released yet). So if you beta-test it and report regressions/problems, I can provide a build 😄

    Awesome. Can confirm that mouse/keyboard control is working well in this version. Anything else specific you need tested?

    👍React with 👍1Reacted by BertP
15. rom1v

    closed this as completedin 5bd7514on Jun 21, 2023
16. Yaoojq commented on Jun 28, 2023

    

    Yaoojq

    on Jun 28, 2023

    Last edited by Yaoojq

    More actions

    I can see the screen on my computer, but I can't control the phone from the computer

    [server] INFO: Device: Xiaomi 22011211C (Android 13)
    [server] ERROR: Could not invoke method
    java.lang.reflect.InvocationTargetException
    at java.lang.reflect.Method.invoke(Native Method)
    at com.genymobile.scrcpy.wrappers.InputManager.injectInputEvent(InputManager.java:37)
    at com.genymobile.scrcpy.Device.injectEvent(Device.java:192)
    at com.genymobile.scrcpy.Device.injectKeyEvent(Device.java:203)
    at com.genymobile.scrcpy.Device.pressReleaseKeycode(Device.java:211)
    at com.genymobile.scrcpy.Device.pressReleaseKeycode(Device.java:216)
    at com.genymobile.scrcpy.Controller.control(Controller.java:70)
    at com.genymobile.scrcpy.Controller.lambda$start$0$com-genymobile-scrcpy-Controller(Controller.java:90)
    at com.genymobile.scrcpy.Controller$$ExternalSyntheticLambda0.run(Unknown Source:2)
    at java.lang.Thread.run(Thread.java:1012)
    Caused by: java.lang.SecurityException: Injecting input events requires the caller (or the source of the instrumentation, if any) to have the INJECT_EVENTS permission.
    at android.os.Parcel.createExceptionOrNull(Parcel.java:3011)
    at android.os.Parcel.createException(Parcel.java:2995)
    at android.os.Parcel.readException(Parcel.java:2978)
    at android.os.Parcel.readException(Parcel.java:2920)
    at android.hardware.input.IInputManager$Stub$Proxy.injectInputEventToTarget(IInputManager.java:1294)
    at android.hardware.input.InputManager.injectInputEvent(InputManager.java:1153)
    at android.hardware.input.InputManager.injectInputEvent(InputM
17. DerekWuYD commented on Jun 28, 2023

    

    DerekWuYD

    on Jun 28, 2023

    ContributorAuthor

    More actions

    This may help you.
    https://github.com/Genymobile/scrcpy/blob/master/FAQ.md#mouse-and-keyboard-do-not-work
18. Yaoojq commented on Jun 28, 2023

    

    Yaoojq

    on Jun 28, 2023

    More actions

    It is normal after the device is restarted