Repository navigation
Refactor: Move rendering to sc_screen and introduce sc_texture - #6651
Merged
Merged
Conversation
When the scrcpy window is minimized on Windows with D3D9, texture creation and updates fail. As a workaround, a mechanism was implemented to reattempt applying the requested changes. Since SDL3 defaults to the D3D11 backend, remove this workaround, which adds a lot of complexity for a backend that should almost never be used. However, do not close scrcpy when texture creation or updates fail; only that specific rendering should fail. Refs SDL/#7651 <libsdl-org/SDL#7651> Refs #3947 <#3947> Refs 6298ef0 PR #6651 <#6651>
Three components are involved in displaying device content on screen: - a window - a renderer - a texture Originally, all three were handled by sc_screen. Commit 051b74c later extracted the renderer and texture into a separate component, sc_display. However, the split was a bit awkward because the window size and rendering location were managed by separate components. Move rendering back to sc_screen, keeping only texture management separated. PR #6651 <#6651>
This was referenced Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three components are involved in displaying device content on screen:
Originally, all three were handled by
sc_screen.Commit 051b74c later extracted the renderer and texture into a separate component,
sc_display.However, the split was a bit awkward because the window size and rendering location were managed by separate components.
Move rendering back to
sc_screen, keeping only texture management separated insc_texture.BEFORE:
AFTER: