Repository navigation
feat(kde): add a native Plasma System Settings page for Gaze - #785
Merged
Merged
Conversation
Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
…tes faces Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
…page backend Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
…he GNOME page Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
…-kde package Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
…tings page for RPM packages Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
…n window Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
… the settings Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
Contributor
Author
|
Hello @pranavgundu I know that PR is slightly large but I wanted to have complete sense of experience and try to follow GNOME UI as much as possible to making sure they we have same experience and nothing left out. I hope it will be added because this would be huge for KDE side maybe one comment I would see not "system kcm" category but security would be better but I didn't touch it. Anyway if you want to you can do changes as well but generally now have proper Kirigami/KDE based on UI and KCM (system settings plugin) too :) |
Member
|
Can you please follow the PR template? |
Contributor
Author
Done |
Member
|
Can you fill in the AI disclosure section? |
Contributor
Author
I added it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Kirigami page under System Settings, backed by a small C++ plugin (Qt6 and KDE Frameworks 6) that talks to gazed over D-Bus, that lists, adds, renames and deletes faces with a live camera preview, tests authentication, and edits every Gaze setting behind a polkit unlock, with a Restart Service button. The RPM gaze-kde package ships it in place of the gaze-gui launcher, and a Gaze Settings launcher opens it in its own window. Only the RPM package ships the page for now: deb and Arch keep the old Face Unlock entry because their package builds have no KDE Frameworks 6 development files, Flatpak is unchanged because a sandboxed app cannot add a System Settings plugin, and Nix is unchanged because the NixOS module only mirrors the lock screen PAM setup and has no package to carry the page.
Related issues
Closes #343.
Type of change
Areas touched
Verification
Required checks. All jobs on this PR are green: Format, Lint, Test, Audit, Build, KDE, GNOME, Nix, and the deb, archlinux, Fedora rpm, openSUSE rpm, srpm and flatpak package jobs. Locally
node scripts/test-kde.mjspasses 160 of 160, and the Fedora gaze-kde RPM builds with nfpm.Tests.
just test-kcm), and enrollment, Test, unlock and restart need a camera or the running daemon.Manual verification. Tested on Fedora, Plasma 6.7.5, Intel NPU laptop. Open System Settings, find Gaze under System Administration, unlock with the administrator password, enroll, rename and delete a face, run Test, switch the security level to Custom, change the OpenVINO device between cpu and npu, then press Restart Service. Result: the changes save, the service restarts and the page reloads.
Licensing
just auditdoes not. The only new dependencies are Qt6 and KF6 libraries (LGPL or GPL compatible), linked dynamically from the distro, and there are no new Cargo crates.GPL-3.0-or-laterFollow-ups and known limitations
This is the first C++ code in the repo, so
just fmt-check,just lintandjust auditdo not cover it, and only the CMake build in the RPM jobs does. The openSUSE package names for the KF6 build dependencies were only confirmed by the CI job, and I did not try a Copr build(Because I build locally so I can repro RPM spec) or a Nix build. deb, Arch, Flatpak and Nix do not get the page yet.AI disclosure
Screenshots