This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Cawbird can generate too many notifications on first login #137
Description
Describe the bug
A twitter user said (in Portuguese - translation by Google Translate):
"I installed a twitter app for ubuntu that calls cawbird, at the first login [it] simply displayed all the notifications I had since I did the account, I was scared until now, but the mass is very light"
To Reproduce
- Have an account with lots of existing notifications
- Add the account to Cawbird
- Maybe something in the "notifications" settings
Expected behavior
Cawbird doesn't spam loads of notifications. If anything, it should probably be silent on that first login.
Screenshots
System details:
- OS: Unknown
- Version: Unknown
- Package type: Unknown
Activity
philipzae commentedon Apr 19, 2020
This happened to me as well when i first log into a new account on cawbird and it assumes a number of my DMs hadnt been seen before, etc. and shows alot of notifications.
IBBoard commentedon Sep 3, 2020
Is this still a problem? I'm struggling to recreate this at the moment. I've added and removed my test account (https://twitter.com/IBBTwtr) and I'm not seeing a flood of messages for the @-mentions. I'm still waiting for the DMs to appear.
[edit] Ah, yes, I can make it happen with DMs. Gnome seems to stack them all together or replace them or something, though, so I get a short flurry of it trying to show each notification and then it just says "3 new messages from IBBoard".
IBBoard commentedon Sep 3, 2020
Just found some code with a comment that says "Ignore the mention if both accounts are configured in Cawbird". That may be why I wasn't seeing notifications when I added my test account, which only gets mentioned by one of my other accounts that's configured in Cawbird!
IBBoard commentedon Sep 3, 2020
Okay, I can't recreate the mentions issue right now - and I think it's mainly because we already ignore every mention that gets loaded in the first load. Which suggests the user might have been suffering from #9 and the first load failed, we unset the "suppress mentions notifications" flag, and then it tries again and loads all of the mentions and triggers a notification for each one.
The DMs are a little harder. I'm currently fighting against some async code to make it suppress the notifications. But the bigger question is how we handle the initial DMs. Do we pretend the user has seen them all? Because there might be DMs that they haven't seen and they won't know. Or do we keep the unread marker but just suppress the notification? Which is inconsistent (we'll notify and show the unread marker in future) but less intrusive.