You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Would be good to keep the icon at the bottom of the image as well, as many of the bulbs aren't touching the image. If that is difficult, then possibly the top left or top right corner.
Yeah, I saw one recently that was less obvious because of the content in the image. But I feel like we should be using the system theme's icon here because it's consistent for the user. And even the blue circle with an "i" won't be entirely obvious on some (blue) backgrounds.
I would try to put a "glow" around it, like I did recently with the upload progress icons, but I don't think there's an obvious/reliable way to do that when you've got an icon instead of an SVG component with a border.
Yeah, I saw one recently that was less obvious because of the content in the image. But I feel like we should be using the system theme's icon here because it's consistent for the user. And even the blue circle with an "i" won't be entirely obvious on some (blue) backgrounds.
Is the penguin icon using the system theme? This definitely has to be an icon provided by penguin and not left to the theme, especially as there is no setting in cawbird to change which icon theme should be used in the cawbird interface. But whatever icon that would be used needed to be able to work on any possible background, maybe by having a black stroke around it.
The penguin for the emoji is whatever your system font provides, because it's text on a button. My system gets it from Noto Color Emoji.
I guess the "work on any possible background" requirement might be a good enough reason to break from system themes. I try not to and I intentionally stripped back Cawbird's custom themeing a while back (hence the loss of the black action bar, because it's fine in Ubuntu but not right for stock Adwaita), but there's always exceptions to every rule.
Activity
IBBoard commentedon Jan 20, 2021
It's slightly less intrusive with the Tango icon theme, which uses a lightbulb.
But you're right, 24px probably isn't too small.
Realign media images to bottom
philipzae commentedon Jan 20, 2021
Would be good to keep the icon at the bottom of the image as well, as many of the bulbs aren't touching the image. If that is difficult, then possibly the top left or top right corner.
IBBoard commentedon Jan 20, 2021
You mean like e7cfd69, which I did about an hour ago, just after the size fix? 😁
philipzae commentedon Jan 20, 2021
On my other PC which shows a bulb, I think it is problematic to leave it up to the theme to decide what icon to show.
philipzae commentedon Jan 20, 2021
😁
philipzae commentedon Jan 20, 2021
Another one that i barely even new had it
IBBoard commentedon Jan 21, 2021
Yeah, I saw one recently that was less obvious because of the content in the image. But I feel like we should be using the system theme's icon here because it's consistent for the user. And even the blue circle with an "i" won't be entirely obvious on some (blue) backgrounds.
I would try to put a "glow" around it, like I did recently with the upload progress icons, but I don't think there's an obvious/reliable way to do that when you've got an icon instead of an SVG component with a border.
philipzae commentedon Jan 21, 2021
Is the penguin icon using the system theme? This definitely has to be an icon provided by penguin and not left to the theme, especially as there is no setting in cawbird to change which icon theme should be used in the cawbird interface. But whatever icon that would be used needed to be able to work on any possible background, maybe by having a black stroke around it.
IBBoard commentedon Jan 22, 2021
The penguin for the emoji is whatever your system font provides, because it's text on a button. My system gets it from Noto Color Emoji.
I guess the "work on any possible background" requirement might be a good enough reason to break from system themes. I try not to and I intentionally stripped back Cawbird's custom themeing a while back (hence the loss of the black action bar, because it's fine in Ubuntu but not right for stock Adwaita), but there's always exceptions to every rule.
Re #294: Reduce "info" overlay icon size
Realign media images to bottom