This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Strings missing for translation on edit list screen #362
Description
Describe the bug
When editing a list in current unstable, some strings are still in English
To Reproduce
Steps to reproduce the behavior:
- Use a locale not English
- Click on 'Lists'
- Click on an existing, empty list
- The contents of "Mode" and "No entries found" are in English
Screenshots
Activity
gunchleoc commentedon Apr 9, 2021
P.S: Spelling right-click menus (language / Spelling Suggestions) also have untranslatable English strings in them.
IBBoard commentedon Apr 10, 2021
Looks like Private/Public is going to be tricky because Baedert used it as both the value and the string. It can be done, but we still need to pass "private" or "public" to Twitter.
"No entries found" was trying to be translatable, but it got missed out of the "translate these files" list.
Re #362: Make list boxes translatable
IBBoard commentedon Apr 10, 2021
Can I have a screenshot of the spelling suggestions? I think it might be out of our control. I can't find "Spelling" anywhere in the code base, and it's almost certainly added by gspell automatically.
Re #362: Make static list status translatable
gunchleoc commentedon Apr 10, 2021
I can't get a screenshot because it is blocking the print screen button. To reproduce, compose a new tweet, type some nonsense and right-click on it.
gspell is only 76 words, so I've done the translation and the next Gnome update should fix it.
Let's put this on low priority.
IBBoard commentedon Apr 10, 2021
That's inconvenient! I tend to use Glimpse in those situations and do a time-delayed screenshot. (Other image editors and/or screenshot tools may be available 😉)
Just to confirm, is "Spelling Suggestions…" in there? If so then I'll close this until we find bugs.
It wasn't too bad in the end. I'll update Unstable so that you can test 03210f7.
gunchleoc commentedon Apr 12, 2021
Dug, I could have taken a time delayed screenshot with GIMP. "Spelling Suggestions…" is part of the gspell package, so let's consider this one solved.
"No entries found" is still in English.
gunchleoc commentedon Apr 12, 2021
I have found a final untranslatable string,
Customin the translation engine list. Settings -> TweetsRe #362: Make translation site names translatable
IBBoard commentedon Apr 12, 2021
"No entries found" is working for me. Maybe I didn't get the patch sorted properly.
I've just added "Custom" (and the other sites, just in case) as translatable. Thanks for being so thorough with the checks!
Builds are in progress. Give it five minutes to finish, and then maybe another five to fifteen to "publish" it to the repo and it should be good. Anything after cawbird_1.3.2-1+94.1 should be updated.
gunchleoc commentedon Apr 13, 2021
Your screenshot for "No entries found" is of the search function, and for slightly different strings too (No user/tweet found). I was on the list screen, after creating a new, empty list and then selecting that list. The string is on Transifex and I translated it 3 days ago. It's still missing from unstable deb version
1.3.2-1+95.1.IBBoard commentedon Apr 13, 2021
That's interesting, because they both use the
ListBoxobject, so it should be the same message! The string isn't anywhere else in the source code. I'll have more of a look.gunchleoc commentedon Apr 13, 2021
Yep, it's strange. Try calling
reset_placeholder_text()to see whether that fixes it?IBBoard commentedon Apr 13, 2021
SearchPage doesn't seem to call the reset, so it would be odd if that fixed it. Putting some debug in beside the two references to "No entries found" and it only ever shows that the translation returns the English. Even on the search page, which definitely shows Gaelic!
[Edit] Wait a minute… the search page says "No tweets found" and "No users found". Which are set in its constructor. The list page is using the default "No entries found" string. Which is set differently.
[Edit 2] Even if I reset during
on_join(which is called every time you switch to a page) then it doesn't get the translated strings, even though SearchPage gets them right in its constructor. Clearly SOMETHING is behaving oddly.IBBoard commentedon Apr 13, 2021
Or it's really trivial and when Gettext has a "fuzzy" string then it defaults to the original text (English in this case) rather than showing a potentially incorrect translation. #facepalm
Fixed by #373. New "unstable" builds have started.
gunchleoc commentedon Apr 13, 2021
Thanks for fixing! 🎉