usr.bin/sqlite3: link the shell against libm (fixes stable/4.0 build)

[laffer1]

Problem

stable/4.0 buildworld fails linking the sqlite3 shell:

ld: error: undefined symbol: ceil
>>> referenced by shell.c:8194 (contrib/sqlite3/shell.c:8194)
>>>               shell.pieo:(seriesFilter)
ld: error: undefined symbol: floor
cc: error: linker command failed with exit code 1
*** [sqlite3.full] Error code 1

Cause

contrib/sqlite3/shell.c's generate_series extension defines
seriesCeil()/seriesFloor() using ceil()/floor(). Under the PIE shell
link those resolve to libm symbols, but usr.bin/sqlite3/Makefile linked
only libsqlite3 (LIBADD+= sqlite3).

Fix

LIBADD+= m.

Verification

cd usr.bin/sqlite3 && make now builds clean — the link picks up -lm
(.../lib/msun -lm) and sqlite3.full links/strips successfully.

Note: master's usr.bin/sqlite3/Makefile is identical (no libm) and likely
needs the same change; happy to send a companion PR.

🤖 Generated with Claude Code

Summary by Sourcery

Build:

• Add libm to the sqlite3 shell link libraries so the build picks up -lm when producing the sqlite3.full binary.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR fixes a link failure for the sqlite3 shell on stable/4.0 by explicitly linking the binary against libm, ensuring math functions used by the generate_series extension resolve correctly under PIE.

File-Level Changes

Change	Details	Files
Ensure sqlite3 shell binary links against libm so ceil/floor resolve correctly in the generate_series extension.	Add libm to the libraries linked for the sqlite3 shell via LIBADD Keep existing linkage against libsqlite3 unchanged and minimal, without broader Makefile refactors	usr.bin/sqlite3/Makefile

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[gemini-code-assist]

Code Review

This pull request updates the Makefile for the sqlite3 utility to link against the math library by adding LIBADD+= m. There are no review comments, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}