Repository navigation
Adding new Wayland-compatible color picker - #5675
Merged
Merged
Conversation
…g only from the OpenShot main window.
…t: Pick Screen Color"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding new Wayland compatible color picker, which allows color picking only from the OpenShot main window. Somewhere over the past year or two, Wayland has become incompatible with the default QColorDialog which ships with Qt. While this might be fixed eventually, it doesn't resolve the issue for existing users and older versions of Qt. So, in an effort to regain the ability for all OpenShot color pickers to function, I have made a new OpenShot-specific color picker. It allows the user to choose from any color on the main window of OpenShot, including the video preview.