Repository navigation
3.x: improve combineLatest method names #6634
Description
Calling combineLatest from Kotlin is a bit awkward. The function has a lot of different parameters, including Iterable, Array as well as 2-x call sites for passing multiple Observables.
Is it possible to prefix these so we have some kind of combineLatestFromIterable which takes the Iterable<T>:
-public static <T, R> Observable<R> combineLatest(Iterable<? extends ObservableSource<? extends T>> sources, Function<? super Object[], ? extends R> combiner) {
+public static <T, R> Observable<R> combineLatestFromIterable(Iterable<? extends ObservableSource<? extends T>> sources, Function<? super Object[], ? extends R> combiner) {and then combineLatest which takes the 2-x call sites.
public static <T1, T2, R> Observable<R> combineLatest(
ObservableSource<? extends T1> source1, ObservableSource<? extends T2> source2,
BiFunction<? super T1, ? super T2, ? extends R> combiner) {The array call we could call combineLatestFromArray.
-public static <T, R> Observable<R> combineLatest(ObservableSource<? extends T>[] sources, Function<? super Object[], ? extends R> combiner) {
+public static <T, R> Observable<R> combineLatestFromArray(ObservableSource<? extends T>[] sources, Function<? super Object[], ? extends R> combiner) {What should we do with?
public static <T, R> Observable<R> combineLatest(Function<? super Object[], ? extends R> combiner, int bufferSize, ObservableSource<? extends T>... sources) {Is it really required? Callers could just use the array overload.
combineLatestDelayError is equivalent and could get the method name improvements as well.
Other methods, such as concat/merge could benefit from this change too.
Activity
akarnokd commentedon Aug 27, 2019
combineLatestArraywould be reasonable and match the otherxArraymethod names. What's the conflict betweencombineLatest(Iterable, F)andcombineLatest(O1, O2, F2)?The varargs variant could be removed.
vanniktech commentedon Aug 27, 2019
There should not be any issues with
combineLatest(Iterable, F)andcombineLatest(O1, O2, F2). I'd just go for consistency. Looking atstartWithIterable.akarnokd commentedon Aug 27, 2019
startWithIterablewas disambiguated due tostartWith(Publisher)and/orstartWith(T)so I'd say is an exception. So if the main trouble is withcombineLatest(O[], F)then let's rename that tocombineLatestArray.zipcould use some name clarification too. There iszip(Iterable(P), F),zipIterable(Iterable(P), bool, int, F),zipArray(F, O...),zip(P(P)).vanniktech commentedon Aug 28, 2019
Closed by #6635 & #6640