Skip to content

Empty constellations in Chinese SC #4987

Closed

Description

@alex-w

In the log I see:

[   221.310][WARN] Empty lines array found for constellation "CON chinese 063" ("天庙")
[   221.311][WARN] Empty lines array found for constellation "CON chinese 092" ("军门")
[   221.323][WARN] Empty lines array found for constellation "CON chinese 150" ("东瓯")
[   221.323][WARN] Empty lines array found for constellation "CON chinese 166" ("器府")
[   221.323][WARN] Empty lines array found for constellation "CON chinese 170" ("天稷")
[   221.336][WARN] Empty lines array found for constellation "CON chinese 264" ("土司空(奎宿)")

Of course these constellations has no stars data for lines. These xingguans was officially deleted in 1752 and I guess we should remove these lines from index.json file.

Activity

  1. added
    dataMissing/bad/outdated data, but no code error
    subsystem: skyculturesThe issue is related to skycultures of planetarium...
    on Jun 18, 2026
  2. sunshuwei commented on Jun 19, 2026

    @sunshuwei
    Contributor

    The six redundant constellations can indeed be deleted. At that time, when there was only this one Chinese Sky Culture, the names of these six constellations were kept merely for the convenience of possible future processing or historical comparison. (Popular science books introducing Chinese Sky Culture usually mention that these six constellations once existed. Now that there are sky cultures from different historical periods, the names of these six constellations indeed no longer need to be retained.

  3. added this to the 26.2 milestone on Jun 19, 2026
  4. alex-w commented on Jun 19, 2026

    @alex-w
    MemberAuthor

    The six redundant constellations can indeed be deleted. At that time, when there was only this one Chinese Sky Culture, the names of these six constellations were kept merely for the convenience of possible future processing or historical comparison. (Popular science books introducing Chinese Sky Culture usually mention that these six constellations once existed. Now that there are sky cultures from different historical periods, the names of these six constellations indeed no longer need to be retained.

    Thanks, these constellations was removed from JSON file

  5. added a commit that references this issue on Jun 19, 2026
    7895f50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

dataMissing/bad/outdated data, but no code errorsubsystem: skyculturesThe issue is related to skycultures of planetarium...

Type

No type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions