Repository navigation
Fix code scanning alert no. 21: DOM text reinterpreted as HTML - #3918
Merged
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
alex-w
marked this pull request as ready for review
September 28, 2024 16:35
alex-w
added
the
state: published
|
Hello @alex-w! Please check the fresh version (development snapshot) of Stellarium: |
alex-w
removed
the
state: published
|
Hello @alex-w! Please check the latest stable version of Stellarium: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/Stellarium/stellarium/security/code-scanning/21
To fix the problem, we need to ensure that the
selectionvariable is properly encoded before being used in the URL. This can be achieved by using a function that encodes the value to make it safe for inclusion in a URL. The best way to do this is to use theencodeURIComponentfunction, which encodes a URI component by replacing each instance of certain characters with one, two, or three escape sequences representing the UTF-8 encoding of the character.selectionvariable is concatenated into the URL string to useencodeURIComponent(selection).initControlsfunction, specifically on line 57.Suggested fixes powered by Copilot Autofix. Review carefully before merging.