Skip to content

Allow excluding names from unwanted references - #4147

Merged
alex-w merged 3 commits into
masterfrom
allow-reference-exclusion
Feb 23, 2025
Merged

alex-w merged 3 commits into
masterfrom
allow-reference-exclusion

Conversation

@gzotti

@gzotti gzotti commented Feb 22, 2025

Copy link
Copy Markdown
Member

Description

Some DSO names are a bit too fanciful for the taste of some users. This branch allows at least manual exclusion of
unwanted sources using a new entry in config.ini

In addition, it finally allows (manually) configuring use of alternative nebula sets in addition to "default". Not sure how relevant this is, though. It may be useful to create own collections, or those with drawings, if there is ever enough material for that.

Fixes #11

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

How Has This Been Tested?

Test Configuration:

  • Operating system: Windows 11
  • Graphics Card: irrelevant

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

- also allows supporting more than one nebula aet.
- Docfixes
- SUG: describe how to do that
@gzotti gzotti added feature Entirely new feature importance: medium A bit annoying, minor miscalculation, but no crash labels Feb 22, 2025
@gzotti gzotti added this to the 25.1 milestone Feb 22, 2025
@gzotti gzotti self-assigned this Feb 22, 2025
@github-actions

Copy link
Copy Markdown

Hello @gzotti!

Thank you for proposing of the feature.

@github-actions
github-actions Bot requested review from 10110111 and alex-w February 22, 2025 21:57
@github-actions

Copy link
Copy Markdown

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

Files matching guide/**:

  • Did you remember to update screenshots to match new updates?
  • Did you remember to grammar check in changed part of documentation?

This is an automatically generated QA checklist based on modified files.

Comment thread src/core/modules/NebulaMgr.cpp Resolved
Comment thread src/core/modules/NebulaMgr.cpp Resolved
Comment thread src/core/modules/NebulaMgr.hpp Resolved
@alex-w
alex-w merged commit 66688df into master Feb 23, 2025
@alex-w
alex-w deleted the allow-reference-exclusion branch February 23, 2025 14:57
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Feb 24, 2025
@github-actions

Copy link
Copy Markdown

Hello @gzotti!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Mar 23, 2025
@github-actions

Copy link
Copy Markdown

Hello @gzotti!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Entirely new feature importance: medium A bit annoying, minor miscalculation, but no crash

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some DSO names are dubious

3 participants