Skip to content

Compute position angle and separation of binary stars system - #4184

Merged
alex-w merged 1 commit into
Stellarium:masterfrom
henrysky:binary_pa_separation
Mar 8, 2025
Merged

alex-w merged 1 commit into
Stellarium:masterfrom
henrysky:binary_pa_separation

Conversation

@henrysky

@henrysky henrysky commented Mar 8, 2025

Copy link
Copy Markdown
Contributor

For those binary system modelling in #4095, compute and display their position angle & separations.

Fixes #363

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

How Has This Been Tested?

Test Configuration:

  • Operating system: MacOS 15
  • Graphics Card: Apple M3

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions

github-actions Bot commented Mar 8, 2025 •

Copy link
Copy Markdown

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files.

@alex-w alex-w added this to the 25.1 milestone Mar 8, 2025

@alex-w alex-w left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alex-w alex-w linked an issue Mar 8, 2025 that may be closed by this pull request
@alex-w

alex-w commented Mar 8, 2025

Copy link
Copy Markdown
Member

@henrysky could you check #2429 please? Probably we can use orbital data from italian website https://www.stelledoppie.it/index2.php?section=2

@alex-w

alex-w commented Mar 8, 2025 •

Copy link
Copy Markdown
Member

Other problem: I don’t have access to The Washington Double Star Catalog anymore, so, I can’t update data in Stellarium according to changes in our star catalogs (see #425).

Who want and can update WDS data in Stellarium?

@alex-w alex-w added the subsystem: catalogs The issue is related to supported catalogs of planetarium... label Mar 8, 2025
@henrysky

henrysky commented Mar 8, 2025 •

Copy link
Copy Markdown
Contributor Author

I can deal with the Washington Double Star Catalog by querying SIMBAD as part of the star catalog generation pipeline in the future, but I won't have much free time in the next few weeks so this won't make it in 25.1 and need to wait until 25.2.

@alex-w

alex-w commented Mar 8, 2025

Copy link
Copy Markdown
Member

I can deal with the Washington Double Star Catalog by querying SIMBAD as part of the star catalog generation pipeline in the future, but I won't have much free time in the next few weeks so this won't make it in 25.1 and need to wait until 25.2.

Previously edition of part of WDS in Stellarium was added by me through adding WDS synonyms for HIP stars and original data from WDS catalog. I fear getting HIP/GaiaDR3 from SIMBAD as synonyms for WDS identifiers may be painful.

In any way version 25.2 is good for me as target.

@gzotti

gzotti commented Mar 8, 2025

Copy link
Copy Markdown
Member

Who want and can update WDS data in Stellarium?

What does one have to do? Just download some list from an URL, or process it? Which tools are involved?

@alex-w

alex-w commented Mar 8, 2025

Copy link
Copy Markdown
Member

Who want and can update WDS data in Stellarium?

What does one have to do? Just download some list from an URL, or process it? Which tools are involved?

My tool for processing - https://github.com/Stellarium/stellarium-data/tree/master/wds

Could anyone check version WDS in VizieR and on official website? Or, better, data in catalogs

@alex-w
alex-w merged commit 5cca5fa into Stellarium:master Mar 8, 2025
@gzotti

gzotti commented Mar 8, 2025

Copy link
Copy Markdown
Member

So, I'd just clone stellarium-data on WSL, run the perl script and commit the changed files?

@alex-w

alex-w commented Mar 8, 2025

Copy link
Copy Markdown
Member

So, I'd just clone stellarium-data on WSL, run the perl script and commit the changed files?

No, perl script just convert the data… So, OK, I’ll try to get the new data through CDS xmatch tool

@gzotti

gzotti commented Mar 8, 2025

Copy link
Copy Markdown
Member

Well, I could process such data, but please just add a README to the tools to understand the workflow.

  • get data from "URL". (Add additional instructions here when the process requires filling in a form or such...)
  • run "converter" "infile" "outfile" "args"
  • move resulting 'outfile' to 'where it belongs'.
  • add entry in some changelog (?)
  • commit whatever has to be committed

@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Mar 9, 2025
@github-actions

github-actions Bot commented Mar 9, 2025

Copy link
Copy Markdown

Hello @henrysky!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Mar 23, 2025
@github-actions

Copy link
Copy Markdown

Hello @henrysky!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

subsystem: catalogs The issue is related to supported catalogs of planetarium...

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Double stars: Sep and ID wrong position angle & dist for 61 Cygni binary

3 participants