Skip to content

Added Tibetan spelling, transliteration and IPA for Tibetan SC - #5036

Merged
gzotti merged 3 commits into
Stellarium:masterfrom
Guanjin0562:tibetan-sc
Jul 11, 2026
Merged

gzotti merged 3 commits into
Stellarium:masterfrom
Guanjin0562:tibetan-sc

Conversation

@Guanjin0562

Copy link
Copy Markdown
Contributor

Description

This pull request adds the following data for Tibetan sky culture (Tibetan SC):

  • Native Tibetan script (native) for asterisms and zodiac signs.
  • Pronunciation-based transliteration (Tibetan Pinyin).
  • Wylie transliteration (based on spelling).
  • IPA.

The zodiac names are taken from reference [5]. The 27/28 lunar mansion names are from the paper cited as [4]. That paper uses a 28‑mansion system (i.e., it splits Drozhin and Jizhin into two separate mansions). Accordingly, I have updated the mansion data in index.json to reflect 28 mansions (numbered 0–27). This may differ from the previous 27‑mansion survey by @gzotti .

The description.md file has been updated with explanatory notes on the Tibetan script, transliteration, and IPA. The existing "please help us" calls have been kept. I am not certain which transliteration scheme was originally used in the file; I have adopted the Wylie system and Tibetan Pinyin that I am familiar with, but the description text itself remains largely unchanged.

Unfortunately, I have not been able to locate any Tibetan star charts, so I cannot revise the asterism identifications.

I have reviewed the example content related to Tibetan SC in the guide user manual, and I believe it is currently correct and does not require any changes.

Additionally, I noticed that the class="layout" attribute on tables in description.md triggers an assertion error in the Qt CSS parser (qcssparser.cpp:1491) when running in Debug mode. Only after deleting all 'class=' layout 'occurrences can the test be successful This attribute was present in the original file and was not added by me. It is possible that you did not encounter this issue previously. I didn't remove this 'class=' layout 'occurrences in the pull request I submitted. Please check if there are any issues.

Fixes # (issue)

Screenshots (if appropriate):

The display of Tibetan letters here is incorrect, I have already reminded in description.md.

image

The screenshot below shows the 28‑mansion table and the Pleiades star chart from reference [4]:

image image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

How Has This Been Tested?

Test Configuration:

  • Operating system: Windows 11 (23H2)
  • Qt version: 6.5.2 (MSVC 2019, 64-bit)
  • Build configuration: Debug
  • Compiler: MSVC 2022 (17.6.3)
  1. Built Stellarium from source with the description.md containing class="layout" on <table> elements.
  2. Launched Stellarium in Debug mode and switched to the "Tibetan" sky culture (or refreshed the sky culture).
  3. Observed an assertion error popup originating from qcssparser.cpp:1491 in Qt6Cored.dll.
  4. Removed all three occurrences of class="layout" from <table> elements in description.md, rebuilt, and repeated steps 2–3, verified that the assertion no longer appears.

I cannot confirm whether this issue is environment-specific (e.g., specific Qt version or build configuration). Please test in your environment to ensure no regression.

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions

Copy link
Copy Markdown

Great PR! Please pay attention to the following items before merging:

Files matching skycultures/**:

  • Did you remember to update skycultures/CMakeLists.txt file respectively to changes in sky cultures?
  • Did you remember to define classification parameter in sky cultures (see index.json file)?
  • Did you remember to define license parameter in sky cultures (see description.md file)?
  • Did you remember to define region parameter in sky culture (see index.json file)?

This is an automatically generated QA checklist based on modified files.

@alex-w alex-w added the subsystem: skycultures The issue is related to skycultures of planetarium... label Jul 10, 2026
@alex-w alex-w added this to the 26.3 milestone Jul 10, 2026
@gzotti

gzotti commented Jul 10, 2026

Copy link
Copy Markdown
Member

Thanks a lot for adding the scripts! Looks much more authentic now. However, on the Lunar mansions: The Men Tsee Khang emblem clearly shows 27 partitions, of which your cho xin and qi xin seem to have been combined in one mansion. in the rightmost field in the emblem image. Of course I cannot say details, but I interpret the 28 as "no longer in use", and would suggest to prefer using the numbers LM00...LM26 to label the Lunar stations according to the emblem of that institute. The unclarity around alternative 28-count can be mentioned in the text, of course.

@alex-w alex-w left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@gzotti gzotti left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Fine for me now.

@gzotti
gzotti merged commit e22aada into Stellarium:master Jul 11, 2026
14 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Skycultures 2.0 Jul 11, 2026
@Guanjin0562
Guanjin0562 deleted the tibetan-sc branch July 15, 2026 01:50
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Jul 22, 2026
@github-actions

Copy link
Copy Markdown

Hello @Guanjin0562!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Sep 29, 2026
@github-actions

Copy link
Copy Markdown

Hello @Guanjin0562!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

subsystem: skycultures The issue is related to skycultures of planetarium...

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants