Repository navigation
Added Tibetan spelling, transliteration and IPA for Tibetan SC - #5036
Conversation
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
|
Thanks a lot for adding the scripts! Looks much more authentic now. However, on the Lunar mansions: The Men Tsee Khang emblem clearly shows 27 partitions, of which your cho xin and qi xin seem to have been combined in one mansion. in the rightmost field in the emblem image. Of course I cannot say details, but I interpret the 28 as "no longer in use", and would suggest to prefer using the numbers LM00...LM26 to label the Lunar stations according to the emblem of that institute. The unclarity around alternative 28-count can be mentioned in the text, of course. |
|
Hello @Guanjin0562! Please check the fresh version (development snapshot) of Stellarium: |
|
Hello @Guanjin0562! Please check the latest stable version of Stellarium: |
Description
This pull request adds the following data for Tibetan sky culture (Tibetan SC):
The zodiac names are taken from reference [5]. The 27/28 lunar mansion names are from the paper cited as [4]. That paper uses a 28βmansion system (i.e., it splits Drozhin and Jizhin into two separate mansions). Accordingly, I have updated the mansion data in
index.jsonto reflect 28 mansions (numbered 0β27). This may differ from the previous 27βmansion survey by @gzotti .The
description.mdfile has been updated with explanatory notes on the Tibetan script, transliteration, and IPA. The existing "please help us" calls have been kept. I am not certain which transliteration scheme was originally used in the file; I have adopted the Wylie system and Tibetan Pinyin that I am familiar with, but the description text itself remains largely unchanged.Unfortunately, I have not been able to locate any Tibetan star charts, so I cannot revise the asterism identifications.
I have reviewed the example content related to Tibetan SC in the guide user manual, and I believe it is currently correct and does not require any changes.
Additionally, I noticed that the
class="layout"attribute on tables indescription.mdtriggers an assertion error in the Qt CSS parser (qcssparser.cpp:1491) when running in Debug mode. Only after deleting all 'class=' layout 'occurrences can the test be successful This attribute was present in the original file and was not added by me. It is possible that you did not encounter this issue previously. I didn't remove this 'class=' layout 'occurrences in the pull request I submitted. Please check if there are any issues.Fixes # (issue)
Screenshots (if appropriate):
The display of Tibetan letters here is incorrect, I have already reminded in
description.md.The screenshot below shows the 28βmansion table and the Pleiades star chart from reference [4]:
Type of change
How Has This Been Tested?
Test Configuration:
description.mdcontainingclass="layout"on<table>elements.qcssparser.cpp:1491inQt6Cored.dll.class="layout"from<table>elements indescription.md, rebuilt, and repeated steps 2β3, verified that the assertion no longer appears.I cannot confirm whether this issue is environment-specific (e.g., specific Qt version or build configuration). Please test in your environment to ensure no regression.
Checklist: