Skip to content

UI: Add Combobox.InputGroup primitive - #80869

Merged
mirka merged 2 commits into
trunkfrom
add-combobox-input-group
Jul 30, 2026
Merged

UI: Add Combobox.InputGroup primitive#80869
mirka merged 2 commits into
trunkfrom
add-combobox-input-group

Conversation

@mirka

@mirka mirka commented Jul 29, 2026

Copy link
Copy Markdown
Member

What?

Adds the missing Combobox.InputGroup primitive to @wordpress/ui.

Why?

Base UI's Combobox supports an InputGroup wrapper for composing the input with prefix/suffix slots or other elements. Without it, the popup anchors to the bare <input> instead of the full control. The Autocomplete family already exposes this subcomponent.

Specifically, we'll need this component to solve the popover positioning problem raised in review for SearchableChipSelect.

How?

Add a thin InputGroup wrapper around Base UI's Combobox.InputGroup, matching the existing Autocomplete.InputGroup implementation.

Testing Instructions

  1. Run Storybook for @wordpress/ui.
  2. Open Design System / Components / Form / Primitives / Combobox.
  3. Confirm Combobox.InputGroup appears in the subcomponents list.

@mirka mirka self-assigned this Jul 29, 2026
@github-actions github-actions Bot added the [Package] UI /packages/ui label Jul 29, 2026
@mirka mirka added the [Type] Enhancement A suggestion for improvement. label Jul 29, 2026
@mirka
mirka marked this pull request as ready for review July 29, 2026 21:11
@mirka
mirka requested a review from a team as a code owner July 29, 2026 21:11
@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: simison <simison@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Size Change: 0 B

Total Size: 7.76 MB

compressed-size-action

@github-actions

Copy link
Copy Markdown

Flaky tests detected in 1115f4d.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

πŸ” Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/30491091770
πŸ“ Reported issues:

@simison simison left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean and simple πŸ‘

@mirka
mirka merged commit d766a84 into trunk Jul 30, 2026
67 checks passed
@mirka
mirka deleted the add-combobox-input-group branch July 30, 2026 10:38
@github-actions github-actions Bot added this to the Gutenberg 23.8 milestone Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] UI /packages/ui [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants