Performance Tests: Ignore the locally generated artifacts directory - #81024
Merged
Conversation
Mamaduka
added
the
[Type] Automated Testing
manzoorwanijk
approved these changes
Jul 31, 2026
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
PR adds
/test/performance/artifactsto.gitignore.Why?
wp-scripts' Playwright config defaultsWP_ARTIFACTS_PATHtopath.join( process.cwd(), 'artifacts' ), andnpm run test:performanceruns in the@wordpress/performance-testsworkspace — so every local perf run writes results JSON, traces,test-results/, and a cached admin storage state intotest/performance/artifacts/..gitignorealready covers/artifactsand/test/e2e/artifacts, but not this one, so the directory shows up as untracked after each run.CI is unaffected: the performance workflow sets
WP_ARTIFACTS_PATHto$GITHUB_WORKSPACE/artifacts, which the existing/artifactsrule already covers.Testing Instructions
npm run test:performance -- post-editor.spec.jsgit status, thetest/performance/artifacts/should no longer appear.