Declare missing prettier and stylelint workspace dependencies - #81065
Merged
Conversation
- prettier-config tests resolve prettier from the package, so declare it as a devDependency (wp-prettier alias). - tools/stylelint must provide stylelint directly since @wordpress/stylelint-config declares it as a peer dependency.
manzoorwanijk
added
the
[Type] Code Quality
manzoorwanijk
marked this pull request as ready for review
August 3, 2026 06:49
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 7.78 MB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Declares two missing workspace dependencies so packages no longer rely on hoisting from the root:
packages/prettier-config: addprettier(npm:wp-prettier@^3.0.3) as a devDependency.tools/stylelint: addstylelintas a dependency.Why?
prettier-configunit tests resolveprettierfrom within the package (require.resolve( 'prettier' )), but the package never declared it — it's only a peer dependency there.@wordpress/stylelint-config, a dependency oftools/stylelint, declaresstylelintas a peer dependency, so the consuming workspace must provide it directly.Both currently work only because the dependencies happen to be hoisted to the root
node_modules; declaring them explicitly makes the workspaces correct under isolated/linked install strategies.How?
Adds the missing entries to the respective
package.jsonfiles and updates the lockfile.Testing Instructions
npm installnpm run test:unit -- packages/prettier-config— tests pass.npm run lint:css— stylelint still runs.Use of AI Tools
Written with the help of Claude Code, reviewed and tested by the author.