Fix: flaky revisions pagination e2e cross-page diff assertion - #81119
Merged
jorgefilipecosta merged 3 commits intoAug 4, 2026
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 7.81 MB |
jorgefilipecosta
force-pushed
the
fix/flaky-revisions-pagination-boundary-diff
branch
from
August 4, 2026 09:58
8c34b8c to
1940993
Compare
jorgefilipecosta
deleted the
fix/flaky-revisions-pagination-boundary-diff
branch
August 4, 2026 11:23
shail-mehta
pushed a commit
that referenced
this pull request
Aug 12, 2026
Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #80154
Fixes the flaky "should paginate, navigate pages, and diff across page boundaries" e2e test.
After pressing Home the test read the two diff marks with one-shot
textContent()calls, racing the canvas re-renders. Right after the keypress the canvas can still show the previously selected revision's diff, so the first read returns the stale added mark ("105"). While the adjacent page loads, the previous revision is unknown and the paragraph is briefly rendered as wholly added, with no removed mark in the DOM — so the second read auto-waits and lands on the settled cross-page diff ("5"). That producesExpected: 1, Received: 100(105 − 5, always exactly the page size), the signature of every failure recorded in #80154.The reads and the assertion are now wrapped in a polling
expect( async () => { ... } ).toPass()block, so both marks are sampled together and retried until they show a consistent adjacent pair — a straddled sample fails the attempt and is retried instead of failing the test.Testing Instructions
npm run test:e2e -- test/e2e/specs/editor/various/revisions.spec.js --grep "paginate"and verify it passes, e.g. with--repeat-each=10.Expected: 1, Received: 100. With this PR's change the same widened runs pass.The change was developed with the assistance of AI tooling.