Skip to content

ESLint: Remove legacy import suppressions - #81338

Merged
ciampo merged 2 commits into
trunkfrom
codex/81188-remove-import-suppressions
Aug 7, 2026
Merged

ESLint: Remove legacy import suppressions#81338
ciampo merged 2 commits into
trunkfrom
codex/81188-remove-import-suppressions

Conversation

@ciampo

@ciampo ciampo commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Closes #81188.

What?

Completes the dependency-import lint migration by fixing the remaining 62 import/order violations and removing their bulk suppressions. It also removes stale dependency-group comments from documentation, generators, templates, and excluded configuration files.

Why?

The rules now run globally, but the remaining suppressions and unlinted examples still allowed the retired import style to persist or be generated again.

How?

  • Makes the remaining import blocks contiguous and orders built-in dependencies before external and internal dependencies.
  • Prunes every import/order entry from tools/eslint/suppressions.json.
  • Updates contributor guidance and removes stale comments from documentation and scaffolding generators.
  • Adds the merged bulk-cleanup commit to .git-blame-ignore-revs.
  • Keeps dependency-group comments only in the lint rule's tests and documentation.

Testing Instructions

  1. Run npm run lint:js -- --format compact --quiet --prune-suppressions.
  2. Run npm run test:unit -- packages/eslint-plugin/rules/__tests__/dependency-group.js --runInBand.
  3. Run npm run test:unit -- packages/docgen/test packages/readable-js-assets-webpack-plugin/test packages/env/lib/test --runInBand.
  4. Run npm run -w packages/icons build and confirm it creates no additional tracked changes.

Testing Instructions for Keyboard

Not applicable. This PR has no user interface changes.

Use of AI Tools

This PR was authored with Codex and reviewed by the author.

@github-actions github-actions Bot added [Package] Compose /packages/compose [Package] Core data /packages/core-data [Package] Components /packages/components [Package] Blocks /packages/blocks [Package] Editor /packages/editor [Package] Block library /packages/block-library [Package] Block editor /packages/block-editor [Package] Data Controls /packages/data-controls [Package] Edit Widgets /packages/edit-widgets [Package] Icons /packages/icons [Package] Edit Site /packages/edit-site [Package] DataViews /packages/dataviews [Package] Fields /packages/fields [Package] Sync /packages/sync labels Aug 7, 2026
@ciampo ciampo self-assigned this Aug 7, 2026
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Size Change: 0 B

Total Size: 7.82 MB

compressed-size-action

@ciampo ciampo added the [Type] Code Quality Issues or PRs that relate to code quality label Aug 7, 2026
@ciampo
ciampo marked this pull request as ready for review August 7, 2026 12:02
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ciampo <mciampini@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>
Co-authored-by: aduth <aduth@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@tyxla tyxla left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@ciampo
ciampo merged commit 8181ec4 into trunk Aug 7, 2026
58 of 61 checks passed
@ciampo
ciampo deleted the codex/81188-remove-import-suppressions branch August 7, 2026 12:52
@github-actions github-actions Bot added this to the Gutenberg 23.8 milestone Aug 7, 2026
amitraj2203 pushed a commit that referenced this pull request Aug 10, 2026
* ESLint: Remove legacy import suppressions

* ESLint: Align import examples and templates

---

Co-authored-by: ciampo <mciampini@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>
Co-authored-by: aduth <aduth@git.wordpress.org>
shail-mehta pushed a commit that referenced this pull request Aug 12, 2026
* ESLint: Remove legacy import suppressions

* ESLint: Align import examples and templates

---

Co-authored-by: ciampo <mciampini@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>
Co-authored-by: aduth <aduth@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Block editor /packages/block-editor [Package] Block library /packages/block-library [Package] Blocks /packages/blocks [Package] Components /packages/components [Package] Compose /packages/compose [Package] Core data /packages/core-data [Package] Data Controls /packages/data-controls [Package] DataViews /packages/dataviews [Package] Edit Site /packages/edit-site [Package] Edit Widgets /packages/edit-widgets [Package] Editor /packages/editor [Package] Fields /packages/fields [Package] Icons /packages/icons [Package] Sync /packages/sync [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linting: Remove dependency import comments and blank lines repository-wide

2 participants