Skip to content

Block Mover: Add the keyboard shortcut to the buttons' spoken description - #81380

Merged
ntsekouras merged 1 commit into
trunkfrom
a11y/add-shortcut-in-block-movers-for-screen-readers
Aug 11, 2026
Merged

Block Mover: Add the keyboard shortcut to the buttons' spoken description#81380
ntsekouras merged 1 commit into
trunkfrom
a11y/add-shortcut-in-block-movers-for-screen-readers

Conversation

@ntsekouras

Copy link
Copy Markdown
Contributor

What?

Resolves: #51647

For a11y reasons it was suggested to also add the shortcut to the block mover's spoken description.

This PR does that.

I didn't wrap the tooltip shortcut in parentheses as also suggested in the comment, because I didn't find any other tooltip shortcut in the editor that uses them. I think this should be discussed separately if needed and is not limited to the block mover tooltip.

Testing Instructions

  1. Select a block focus the Move up or Move down button in the block toolbar with a screen reader (e.g. VoiceOver).
  2. The description should now end with the shortcut, e.g. "Move Paragraph block from position 2 up to position 1 (Shift + Option + Command + T)".

Screenshots or screencast

Screen.Recording.2026-08-10.at.1.25.36.PM.mov

Use of AI Tools

Generated with Fable 5 and adjusted/reviewed manually.

@ntsekouras ntsekouras self-assigned this Aug 10, 2026
@ntsekouras
ntsekouras requested a review from ellatrix as a code owner August 10, 2026 10:32
@ntsekouras ntsekouras added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Aug 10, 2026
@github-actions github-actions Bot added the [Package] Block editor /packages/block-editor label Aug 10, 2026
@github-actions

Copy link
Copy Markdown

Size Change: +52 B (0%)

Total Size: 7.65 MB

📦 View Changed
Filename Size Change
build/scripts/block-editor/index.min.js 434 kB +52 B (+0.01%)

compressed-size-action

@t-hamano t-hamano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It also works correctly with Windows NVDA.

Image

@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @porg.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: porg.

Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: joedolson <joedolson@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka

Mamaduka commented Aug 11, 2026

Copy link
Copy Markdown
Member

Code looks good.

Does the project include shortcuts in spoken messages anywhere else? Mostly want to know if we're establishing a new pattern?

@ntsekouras
ntsekouras merged commit 63bbebc into trunk Aug 11, 2026
56 of 57 checks passed
@ntsekouras
ntsekouras deleted the a11y/add-shortcut-in-block-movers-for-screen-readers branch August 11, 2026 08:06
@github-actions github-actions Bot added this to the Gutenberg 23.8 milestone Aug 11, 2026
@ntsekouras

Copy link
Copy Markdown
Contributor Author

Does the project include shortcuts in spoken messages anywhere else? Mostly want to know if we're establishing a new pattern?

Shortcuts are announced in a few places already like menu items in block options (from block toolbar) and it seems ui package also tries to do that more and more with aria-keyshortcuts. I don't think we do it for every button that has a shortcut though.

shail-mehta pushed a commit that referenced this pull request Aug 12, 2026
…tion (#81380)

Unlinked contributors: porg.

Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: joedolson <joedolson@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Block editor /packages/block-editor [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move up / Move down action buttons - Tooltip should also show shortcut

3 participants