You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is an alpha release and we would like to ask you to try it out and provide us with your feedback. If you have any questions, ideas or concerns, please share them in this issue.
Thank you!
Reacted by amjed1988
Reacted by Ivan, Josh Dales, Dusan Trickovic, Luca Comellini, sensuikan1973, Sora Morimoto, Wasuwat Limsuparhat, Alexander Brandes, amjed1988, Zemaya366 and 1 more
How about setting dot option to true by default? I can craft a PR if this change is desired. From my personal experience, βspecial treatmentβ of dot files by labeler is somewhat surprising. I guess that the vast majority of developers would want to set dot: true anyway.
Reacted by Jon Dufresne, Sora Morimoto, Josh Dales and Oliver Ford
@MaksimZhukov I've been using the alpha for the past moth in multiple repos and everything works as expected.
Any chance we can get a new alpha/beta with all the new features/updates that went into main? π
Thank you @lucacome for the feedback, we really appreciate it!
We are considering the possibility of expanding the functionality of the alpha version. As soon as we finish the investigation, we will make appropriate changes, if necessary, and release a stable version.
Thank you for your patience!
Reacted by Luca Comellini, Josh Dales and Wasuwat Limsuparhat
Hi @MaksimZhukov, I can confirm it fixes the issues with the sync-labels. The fact that this version adds labels based on branch names, is an excellent feature. Thanks for all the effort and time you devoted to this action β€οΈ
Hello everyone!
We've released a new beta version of the action. The configuration file structure was changed to provide more flexibility for changed-files. For more information, see the release notes and this issue.
If you have any questions, ideas or concerns, please share them in this issue.
Thanks for the updates in the new beta version - I was wondering why not use consistent casing for all the config keys names? eg. the new changed-files nested keys are all in PascalCase now rather than kebab-case. Would it not be better to have them all be the same?
I realise that some of this might be my fault as I added some of those keys π I personally don't have a preference, I just went with kebab-case initially because it was the same as the action config, but if the nested changed file options are how y'all would rather future keys are then might make sense to switch changed-files, head-branch, base-branch as well?
Have the outputs changed or gone away in the beta? I originally used version 4 of the action and grabbed a snippet that outputs the new-labels and all-labels for the run. When I switched to the beta version, this step no longer outputs any labels even if some were added.
Is there anyway someone can squeeze #688 in to the v5 release please? We title our PRs with [FEATURE], [BUG], [CHORE], etc. and it would be nice to auto-label based off of that so we can automate our release notes. π
Reacted by Mihkel Sokk, justin-kidman-axomic, Dmitrii Maliukov, Ettore Di Giacinto and Ben Fielden
@MaksimZhukov May I second that dot: true by default would be good - afaict the only reason to add it default false was to avoid it being a breaking change, so why not break now with the v5?
I can't think of any reason someone would want not to match dotfiles on path specs that do match them, it's not as if it's something weird & controversial like an 'implied dot' where '^foobar$' matches both 'foobar' and '.foobar'. It's just a random gotcha.
Hello everyone!
We have released the new major version of the action. In the new version, dot input is set to true by default. It also contains a bunch of other important changes. Please read the action documentation to find out how to adapt your configuration files and workflows for use with the new action version.
Thank you all for your feedback and patience! We really appreciate this!
Do not hesitate to contact us if you have any questions!
Reacted by Alexander Kachkaev, Josh Dales, Luca Comellini, Oliver Ford and Jorge Martinez
Activity
kachkaev commentedon Jun 5, 2023
How about setting
dotoption totrueby default? I can craft a PR if this change is desired. From my personal experience, βspecial treatmentβ of dot files by labeler is somewhat surprising. I guess that the vast majority of developers would want to setdot: trueanyway.MaksimZhukov commentedon Jun 6, 2023
@kachkaev Thanks for the suggested idea! We will consider adding it to the new major release.
lucacome commentedon Jun 23, 2023
@MaksimZhukov I've been using the alpha for the past moth in multiple repos and everything works as expected.
Any chance we can get a new alpha/beta with all the new features/updates that went into
main? πMaksimZhukov commentedon Jun 29, 2023
Thank you @lucacome for the feedback, we really appreciate it!
We are considering the possibility of expanding the functionality of the alpha version. As soon as we finish the investigation, we will make appropriate changes, if necessary, and release a stable version.
Thank you for your patience!
jorgepiloto commentedon Aug 10, 2023
Hi @MaksimZhukov, I can confirm it fixes the issues with the
sync-labels. The fact that this version adds labels based on branch names, is an excellent feature. Thanks for all the effort and time you devoted to this action β€οΈMaksimZhukov commentedon Sep 20, 2023
Hello everyone!
We've released a new beta version of the action. The configuration file structure was changed to provide more flexibility for
changed-files. For more information, see the release notes and this issue.If you have any questions, ideas or concerns, please share them in this issue.
dfandrich commentedon Sep 21, 2023
There seems to be a different bug with
sync-labelsnow. When not explicitly settingsync-labelsin the GHA job file, the job errors out withThere needs to be an explicit
sync-labels: falsein the workflow file to avoid this; it can't be left out to rely on the default false value.MaksimZhukov commentedon Sep 21, 2023
@dfandrich, thank you for reporting this! Could you please create a new issue?
joshdales commentedon Sep 22, 2023
Thanks for the updates in the new beta version - I was wondering why not use consistent casing for all the config keys names? eg. the new
changed-filesnested keys are all in PascalCase now rather than kebab-case. Would it not be better to have them all be the same?I realise that some of this might be my fault as I added some of those keys π I personally don't have a preference, I just went with kebab-case initially because it was the same as the action config, but if the nested changed file options are how y'all would rather future keys are then might make sense to switch
changed-files,head-branch,base-branchas well?MaksimZhukov commentedon Sep 25, 2023
@joshdales, this is a great point, thank you. We will switch the nested options to kebab-case
cwire4 commentedon Oct 3, 2023
Have the outputs changed or gone away in the beta? I originally used version 4 of the action and grabbed a snippet that outputs the new-labels and all-labels for the run. When I switched to the beta version, this step no longer outputs any labels even if some were added.
This is the step I have in my yaml:
run: |
echo 'New labels:'
echo '${{ steps.labeler.outputs.new-labels }}'
echo '-------------------------'
echo 'All labels:'
echo '${{ steps.labeler.outputs.all-labels }}'
The previous step's id is still labeler.
dfandrich commentedon Oct 3, 2023
onesneakymofo commentedon Nov 3, 2023
Is there anyway someone can squeeze #688 in to the v5 release please? We title our PRs with [FEATURE], [BUG], [CHORE], etc. and it would be nice to auto-label based off of that so we can automate our release notes. π
OJFord commentedon Nov 22, 2023
@MaksimZhukov May I second that
dot: trueby default would be good - afaict the only reason to add it defaultfalsewas to avoid it being a breaking change, so why not break now with the v5?I can't think of any reason someone would want not to match dotfiles on path specs that do match them, it's not as if it's something weird & controversial like an 'implied dot' where '^foobar$' matches both 'foobar' and '.foobar'. It's just a random gotcha.
MaksimZhukov commentedon Dec 5, 2023
Hello everyone!
We have released the new major version of the action. In the new version,
dotinput is set totrueby default. It also contains a bunch of other important changes. Please read the action documentation to find out how to adapt your configuration files and workflows for use with the new action version.Thank you all for your feedback and patience! We really appreciate this!
Do not hesitate to contact us if you have any questions!