Skip to content

Update node16 to latest version - #2736

Merged
takost merged 9 commits into
mainfrom
takost/update_latest_node16
Aug 9, 2023
Merged

takost merged 9 commits into
mainfrom
takost/update_latest_node16

Conversation

@takost

@takost takost commented Aug 7, 2023 •

Copy link
Copy Markdown
Contributor

Update node16 to latest version - 16.20.1.
Node.js will be updated to 16.20.1 for all platforms except windows win-arm64, as this platform doesn't have this release. win-arm64 will be updated to latest available version 16.20.0

@takost
takost requested a review from a team as a code owner August 7, 2023 13:14
Comment thread src/Misc/externals.sh
# todo: replace these with official release when available
acquireExternalTool "$UNOFFICIAL_NODE_URL/v${NODE16_VERSION}/$PACKAGERUNTIME/node.exe" node16/bin
acquireExternalTool "$UNOFFICIAL_NODE_URL/v${NODE16_VERSION}/$PACKAGERUNTIME/node.lib" node16/bin
acquireExternalTool "$UNOFFICIAL_NODE_URL/v${NODE16_UNOFFICIAL_VERSION}/$PACKAGERUNTIME/node.exe" node16/bin

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for explicit naming

@fhammerl fhammerl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takost
takost merged commit e752edf into main Aug 9, 2023
@takost
takost deleted the takost/update_latest_node16 branch August 9, 2023 10:50
ashb pushed a commit to ashb/runner that referenced this pull request Aug 10, 2023
* Update node16 to latest

* add available version for win-arm64

* fix externals hash

@KramNosaj01 KramNosaj01 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/Misc/contentHash/externals/linux-arm
src/Misc/contentHash/externals/linux-arm64
src/Misc/contentHash/externals/osx-arm64
src/Misc/contentHash/externals/osx-x64
src/Misc/contentHash/externals/win-arm64
src/Misc/contentHash/externals/win-x64
src/Misc/externals.sh
takost/update_latest_node16

@KramNosaj01 KramNosaj01 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

takost/update_latest_node16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants