Skip to content

Filter comments by content instead of actor - #519

Merged
luketomlinson merged 4 commits into
mainfrom
bugfix/518-comment-filtering
Jul 12, 2021
Merged

luketomlinson merged 4 commits into
mainfrom
bugfix/518-comment-filtering

Conversation

@luketomlinson

Copy link
Copy Markdown
Collaborator

Changes

Fixes #509
Fixes #441
Fixes #518

@luketomlinson
luketomlinson requested a review from a team as a code owner July 1, 2021 21:06

@C0ZEN C0ZEN left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good

@C0ZEN C0ZEN left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think this line should be updated?

stale/README.md

Line 312 in 678bfc7

Only the [actor](#repo-token) and the batch of issues (100 per batch) will consume the operations.

@luketomlinson
luketomlinson merged commit d901397 into main Jul 12, 2021
@luketomlinson
luketomlinson deleted the bugfix/518-comment-filtering branch July 12, 2021 14:37
Emperorywh pushed a commit to Emperorywh/foxglove-opensource that referenced this pull request Aug 6, 2026
This might make the actions bot better about removing the stale label when there have been new comments. See: actions/stale#519
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't filter comments by actor stale label not removed from issue that had an update Stale label not being removed after new activity

2 participants