Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Support rebeccapurple #10250

Closed
Closed
Support rebeccapurple#10250
Assignees
redmunds
Labels
F Color Pickerfix in progresslow priority
Milestone
Release 1.2

Description

@le717
le717
opened on Dec 20, 2014

Both LESS 2.0 and Sass 3.4 support recbeccapurple #663399. All browsers and IE 11+ supports it. Right now, trying to use Quick Edit on the color results in a "No Quick Edit Available" message.

This would also require updating our copy of TinyColor to v1.1.1, the newest (and currently only) version of TinyColor to support it. However, the author made breaking API changes in v1.0 that breaks QE.

(Side note: I've already updated TinyColor and fixed the API calls in #9596).

Activity

  1. redmunds commented on Dec 20, 2014

    @redmunds
    redmunds
    on Dec 20, 2014
    Contributor

    @le717 The regex used by Quick Edit is in utils/ColorUtils.js. Can you add it and submit a pull request?

  2. le717 commented on Dec 20, 2014

    @le717
    le717
    on Dec 20, 2014
    ContributorAuthor

    Done. It enables QE on rebeccapurple, but we would still need to update TinyColor for full support, as you can see in this image.

    Not rebeccapurple

    I can always submit a PR that only updates TinyColor and the API calls separately. IIIRC, there were not that many changes to make.

  3. redmunds commented on Dec 20, 2014

    @redmunds
    redmunds
    on Dec 20, 2014
    Contributor

    @le717 It looks like TinyColor has already been updated to support rebecca purple, so we (hopefully) just need to update that library.

  4. le717 commented on Dec 21, 2014

    @le717
    le717
    on Dec 21, 2014
    ContributorAuthor

    @redmunds That's what I have been saying. I personally submitted the patch to TinyColor to support rebeccapurple, and we need to update our copy to pick that up. However, the author has refactored the extension and API since our version from 2012, so the TinyColor API calls in the InlineColorEditor extension will need to be revised.

    I can always submit a PR that only updates TinyColor and the API calls separately [instead of doing it in #9596]. IIIRC, there were not that many changes to make.

  5. redmunds commented on Dec 21, 2014

    @redmunds
    redmunds
    on Dec 21, 2014
    Contributor

    @le717 Sorry, I misread that. I think we should just wait until PR #9596 gets merged.

  6. redmunds
    self-assigned this
    on Dec 21, 2014
  7. redmunds
    added
    low priority
    fix in progress
    F Color Picker
    and removed
    fix in progress
    on Jan 6, 2015
  8. redmunds
    added this to the Release 1.2 milestone on Jan 9, 2015
  9. peterflynn
    removed this from the Release 1.2 milestone on Jan 12, 2015

  10. peterflynn commented on Jan 12, 2015

    @peterflynn
    peterflynn
    on Jan 12, 2015
    Member

    Already in progress, but not considered urgent so removing milestone

  11. le717 commented on Jan 12, 2015

    @le717
    le717
    on Jan 12, 2015
    ContributorAuthor

    @peterflynn Yea, full support is tied up in the complicated PR #9596. :\

  12. redmunds commented on Jan 16, 2015

    @redmunds
    redmunds
    on Jan 16, 2015
    Contributor

    Confirmed. Closing.

  13. redmunds
    closed this as completedon Jan 16, 2015
  14. redmunds
    added this to the Release 1.2 milestone on Jan 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

F Color Pickerfix in progresslow priority

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions