This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Repository navigation
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Code coloring broken for html file with Embedded JavaScript templates (EJS) #4137
Description
Description:
Code coloring broken for html file with Embedded JavaScript templates (EJS). I got this file from the Adobe CSS FilterLab repo: https://github.com/adobe/cssfilterlab/blob/master/index.html
Repro using Brackets Sprint 25 on Win 7 and Mac 10.7.
Repro steps:
- Get this file and open it in Brackets: https://github.com/adobe/cssfilterlab/blob/master/index.html
Actual results:
The code coloring is broken, starting with this tag: <%- css %>.
Expected results:
Code coloring is not broken. Works fine in Sublime Text 2.
Workaround:
None.
Activity
jasonsanjose commentedon Jun 7, 2013
Looks like this works in the code mirror demo http://codemirror.net/mode/htmlembedded/. However, we would either need to
A. Swap
htmlmixedforhtmlembeddedorB. Require EJS files to have a .ejs extension.
I think B is safe for now and we might reconsider A in the future. Eventually users will have the option to override the mode via https://trello.com/c/FaoluhZ5.
Reviewed, low priority to @jasonsanjose.
lkcampbell commentedon Jun 9, 2013
I submitted pull request #4166 that implements solution B.
Merge pull request #4166 from lkcampbell/fix-issue-4137
lkcampbell commentedon Jul 25, 2013
This should be fixed now. At the very least, this bug should be marked FBNC.
lkcampbell commentedon Aug 2, 2013
@dalcala or @jasonsanjose, when you get a moment, please confirm this fix and close this bug.
peterflynn commentedon Aug 3, 2013
It doesn't fix the original bug as filed -- .html files will still get treated as regular HTML -- but that's just a FOL until changing the syntax mode per-file or per-extension is implemented. It's definitely fixed for the .ejs extension, I think we're good to close.