This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Repository navigation
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
[Core][Untitled files][Win only]: Incorrect sort order for untitled files. #4409
Description
Steps:
- Launch Brackets.
- New several untitled files under the same folder.
Result:
The sort order for these untitled files is different with OS sort order. On Brackets, its files order is: Untitled-1.js,Untitled-2.js,Untitled-3.js, Untitled.js, but its untitled folders order is : Untitled,Untitled-1,Untitled-2,Untitled-3. And OS sort order is: Untitled.js, Untitled-1.js,Untitled-2.js,Untitled-3.js.
Expected:
The sort order for untitled files should follow OS sort oder and untitled folders order.
ENV: Win7x64 ENU
Build: 0.27.0.8255
Notes:
On Mac, its sort order for untitled files is same with Win: Untitled-1.js,Untitled-2.js,Untitled-3.js, Untitled.js. But its OS sort order has same behavior. I think maybe MAC and Win follows different sort order rules.
Snapshots:
Please refer to snapshot for details:
Activity
peterflynn commentedon Jul 15, 2013
Reviewed - related to #4332. Move both to backlog.
Merge pull request #4463 from TomMalbran/issues-4332-4409
RaymondLim commentedon Jul 18, 2013
FBNC to @julieyuan
julieyuan commentedon Jul 19, 2013
@RaymondLim I checked this issue in build 0.28.0.8416. Pull request #4463 indeed fixed issue #4332. But another issue occurs. Please refer to snapshot:
This issue also reproduces on MAC. Untitled-25.js is between Untitled-2.js and Untitled-3.js. I don't think it is right behavior. Please help to fix it .Thanks.
RaymondLim commentedon Jul 19, 2013
@TomMalbran
Looks like we need another sorting when filenames end with numbers. Do you want to try it by breaking up the trailing numbers and do a secondary sorting if the filenames w/o trailing numbers are the same? Otherwise, we may have to close this one as "move to backlog."
TomMalbran commentedon Jul 19, 2013
Yes. But I can work on it next week probably.
RaymondLim commentedon Jul 19, 2013
Thanks. If you can get it done by next Tuesday, then we can keep the milestone. Otherwise, I have to move it out to next sprint.
Merge pull request #4524 from TomMalbran/tom/issue-4409
RaymondLim commentedon Jul 23, 2013
FBNC to @julieyuan again. You can verify the remaining issue with b8496.
julieyuan commentedon Jul 24, 2013
Thanks. It is fixed in build 0.28.0.8496. Here is the snapshot:
