Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Windows: PageUp/PageDown collapses selection onlyΒ #6811

Open

Description

@redmunds

This was introduced with CodeMIrror update for Sprint 36: #6268

Recipe:

  1. Select text in page
  2. Hit PageDown

Result:
Text is deselected. Cursor is placed after text that was selected. Editor is not scrolled.

Expected:
Editor is scrolled in addition to Results above

Workaround
Hit PageDown again.

Activity

  1. RaymondLim commented on Feb 10, 2014

    @RaymondLim
    Contributor

    @redmunds This is by design in CM. The first key stroke deselects the selection and navigation keys take effect only if there is no selection. You can see this behavior with Down/Up arrow keys as well, not just with PageUp/PageDown. On Mac the equivalent keys for PageUp/PageDown are fn-Up/Down arrow keys on laptop keyboard.

  2. redmunds commented on Feb 10, 2014

    @redmunds
    ContributorAuthor

    @RaymondLim Was there an announcement explaining why this was recently changed? I've never noticed this behavior in any other editor.

  3. RaymondLim commented on Feb 10, 2014

    @RaymondLim
    Contributor

    @redmunds No announcement that I'm aware of. I reviewed all of the changes in CM and Marijn put a note regarding his decision in either one of the commits or the issues that he fixed. I'll put a link here if I can easily find it again.

    Found it! codemirror/codemirror5#2042

  4. peterflynn commented on Feb 10, 2014

    @peterflynn
    Member

    @RaymondLim It's not something I ever hit personally, but this does seem odd to me -- it's not the behavior in Sublime, WebStorm, Notepad++, or Notepad (or even Word, for that matter). Are there Mac editors that behave this way?

  5. RaymondLim commented on Feb 10, 2014

    @RaymondLim
    Contributor

    @redmunds and @peterflynn I totally agree with you that it's odd. But Marijn's codemirror/codemirror5#2042 (comment) claims that some do.

  6. peterflynn commented on Feb 10, 2014

    @peterflynn
    Member

    It sounds like he's saying that only (some) Linux editors do -- not any on any other platform. That's not particularly helpful for us given that ~90% of our users aren't on Linux...

  7. njx commented on Feb 10, 2014

    @njx

    Medium priority to @RaymondLim. I think we should push back on this change in CodeMirror - if it's literally the case that no other popular Windows or Mac editor works this way, we shouldn't change it just because some Linux editors do. Raymond, could you file a bug in CodeMirror, and maybe double-check a few popular editors in Mac and Win to back up our argument?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions