Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

One DocumentCommandHandlers integration test is failing.Β #7632

Open

Description

@RaymondLim
  1. Select Integration tab in Jasmine window.
  2. Run DocumentCommandHandlers.

Result: You may get one test failure. If not, open Developer toots from Jasmine window and set a breakpoint on line 255. You may see the failure in that test. If not, then cleanup your Brackets cache and start over. Once you get it failing, you can see it failing again when you run DocumentCommandHandlers.

should swap out untitled document from working set even when not current
Error: Expected -1 to be greater than -1.
    at new jasmine.ExpectationResult (file:///C:/Users/rlim/brackets/test/thirdparty/jasmine-core/jasmine.js:102:32)
    at null.toBeGreaterThan (file:///C:/Users/rlim/brackets/test/thirdparty/jasmine-core/jasmine.js:1194:29)
    at null.<anonymous> (file:///C:/Users/rlim/brackets/test/spec/DocumentCommandHandlers-test.js:268:75)
    at jasmine.Block.execute (file:///C:/Users/rlim/brackets/test/thirdparty/jasmine-core/jasmine.js:1024:15)
    at jasmine.Queue.next_ (file:///C:/Users/rlim/brackets/test/thirdparty/jasmine-core/jasmine.js:1842:31)
    at onComplete (file:///C:/Users/rlim/brackets/test/thirdparty/jasmine-core/jasmine.js:1838:18)
    at jasmine.WaitsForBlock.execute (file:///C:/Users/rlim/brackets/test/thirdparty/jasmine-core/jasmine.js:2322:5)
    at file:///C:/Users/rlim/brackets/test/thirdparty/jasmine-core/jasmine.js:2336:12

Activity

  1. changed the title [-]One DocumentComandHandlers integration test is failing.[/-] [+]One DocumentCommandHandlers integration test is failing.[/+] on Apr 28, 2014
  2. njx commented on Apr 28, 2014

    @njx

    Reviewed. High pri to @JeffryBooher to investigate or turn the test off if it's hard to fix.

  3. JeffryBooher commented on May 2, 2014

    @JeffryBooher
    Contributor

    @RaymondLim I'm unable to reproduce this on Windows 8.1
    I tried putting a BP on line 255 of DocumentCommandHandlers-test.js
    I tried clearing my cef_data folder
    Can you still repro with Master?

  4. added this to the Release #39 milestone on May 2, 2014
  5. njx commented on May 2, 2014

    @njx

    Marking Release 39 to investigate. If we can't repro this on dev machines and can't repro it by manually trying the steps, then let's comment out the test for now.

  6. peterflynn commented on May 2, 2014

    @peterflynn
    Member

    I can repro locally, so I'll see if I can find anything out...

  7. peterflynn commented on May 2, 2014

    @peterflynn
    Member

    Actually, now it's not reproducing anymore. Seems to be extremely timing sensitive... will keep trying.

  8. JeffryBooher commented on May 5, 2014

    @JeffryBooher
    Contributor

    Steps:

    1. Create an untitled document and make some changes (don't save)
    2. open another document
    3. save all
      => force to name untitled document
      Untitled document is not renamed in working set
  9. pthiess commented on May 5, 2014

    @pthiess
    Contributor

    @JeffryBooher Failure seems intermittent and was reproduced with Release 38 -- moving this to release 40 (milestone). Reducing priority to medium as @peterflynn suggested.

  10. JeffryBooher commented on May 5, 2014

    @JeffryBooher
    Contributor

    Comment out test and lower to med pri

  11. modified the milestones: Release #40, on May 20, 2014
  12. pthiess commented on May 20, 2014

    @pthiess
    Contributor

    @ingorichter while @JeffryBooher cannot reproduce

  13. removed this from the Release 0.41 milestone on Jun 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions