Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Expose CodeMirror.operation() and replaceRange() on DocumentΒ #803

Closed

Description

@peterflynn

Currently, it's hard to write a command that does text edits without talking directly to Editor._codeMirror, and we don't really want that. If we simply exposed operation() and replaceRange(), it would go a long way toward fixing this.

I'm fudging a little by marking this "code cleanup," but I think it would be a very simple change -- little more than proxying down to the matching methods on Document._masterEditor.

Activity

  1. peterflynn commented on May 3, 2012

    @peterflynn
    MemberAuthor

    Nominating for sprint 8 since it ties in nicely with our extensibility goals

  2. njx commented on May 8, 2012

    @njx

    Assigning to Peter, but let's talk about whether we want to expose the APIs or the object itself.

  3. pthiess commented on May 11, 2012

    @pthiess
    Contributor

    moved to Sprint 9

  4. peterflynn commented on May 24, 2012

    @peterflynn
    MemberAuthor

    Architectural discussion of this work is ongoing here: https://groups.google.com/forum/?fromgroups#!topic/brackets-dev/ok20uf8Q_a4

  5. peterflynn commented on Jun 1, 2012

    @peterflynn
    MemberAuthor

    After discussion with NJ & Glenn, we decided to move this out to the beginning of Sprint 10.

  6. peterflynn commented on Jun 14, 2012

    @peterflynn
    MemberAuthor

    Merged by pull request #980. Document now has equivalents to CodeMirror.operation(), replaceRange(), getRange(), and getLine(). (And Document.getText()/setText() have better semantics).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions