Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Inline editor reveals "Gold" border at timesΒ #8609

Closed

Description

@JeffryBooher

Switch to black
Turn off word-wrap
Open brackets source folder
Open editormanager.js
scroll to line 232 and ctrl+e on "editor.addInlineWidget"
click just to the left of the scroll bar thumb tack
==> ugly gold outline that doesn't has some issues (not all sides are visible)
image

Activity

  1. changed the title [-][THEMES] Inline editor reveals "Gold" border at times[/-] [+]Inline editor reveals "Gold" border at times[/+] on Aug 4, 2014
  2. dangoor commented on Aug 4, 2014

    @dangoor
    Contributor

    This is not strictly themes related. It appears that the focus is going to the DOM node for the whole inline text editor, so that's the actual problem.

    Reviewed low priority in the Quick Edit feature area.

  3. peterflynn commented on Aug 4, 2014

    @peterflynn
    Member

    @JeffryBooher When I try to repro this, the highlight is only visible for an instant -- it appears on mousedown and disappears on mouseup. Is that different from what you're seeing?

    I get the same behavior in simpler repro cases like Getting Started too. And I can see this in much earlier versions, at least as far back as Sprint 33...

  4. JeffryBooher commented on Aug 4, 2014

    @JeffryBooher
    ContributorAuthor

    Yep that's the same behavior. I guess it's more noticeable with the black theme though.

  5. marcelgerber commented on Sep 4, 2014

    @marcelgerber
    Contributor

    @JeffryBooher You can probably close that issue, right?

  6. JeffryBooher commented on Sep 4, 2014

    @JeffryBooher
    ContributorAuthor

    @marcelgerber yep. Looks like it fell through the cracks because the PR was merged and the issue left unassigned and wasn't marked FBNC.

  7. JeffryBooher commented on Sep 4, 2014

    @JeffryBooher
    ContributorAuthor

    Closing as Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions