You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Repository navigation
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Inline editor reveals "Gold" border at timesΒ #8609
Switch to black
Turn off word-wrap
Open brackets source folder
Open editormanager.js
scroll to line 232 and ctrl+e on "editor.addInlineWidget"
click just to the left of the scroll bar thumb tack
==> ugly gold outline that doesn't has some issues (not all sides are visible)
This is not strictly themes related. It appears that the focus is going to the DOM node for the whole inline text editor, so that's the actual problem.
Reviewed low priority in the Quick Edit feature area.
@JeffryBooher When I try to repro this, the highlight is only visible for an instant -- it appears on mousedown and disappears on mouseup. Is that different from what you're seeing?
I get the same behavior in simpler repro cases like Getting Started too. And I can see this in much earlier versions, at least as far back as Sprint 33...
Activity
[-][THEMES] Inline editor reveals "Gold" border at times[/-][+]Inline editor reveals "Gold" border at times[/+]dangoor commentedon Aug 4, 2014
This is not strictly themes related. It appears that the focus is going to the DOM node for the whole inline text editor, so that's the actual problem.
Reviewed low priority in the Quick Edit feature area.
peterflynn commentedon Aug 4, 2014
@JeffryBooher When I try to repro this, the highlight is only visible for an instant -- it appears on mousedown and disappears on mouseup. Is that different from what you're seeing?
I get the same behavior in simpler repro cases like Getting Started too. And I can see this in much earlier versions, at least as far back as Sprint 33...
JeffryBooher commentedon Aug 4, 2014
Yep that's the same behavior. I guess it's more noticeable with the black theme though.
marcelgerber commentedon Sep 4, 2014
@JeffryBooher You can probably close that issue, right?
JeffryBooher commentedon Sep 4, 2014
@marcelgerber yep. Looks like it fell through the cracks because the PR was merged and the issue left unassigned and wasn't marked FBNC.
JeffryBooher commentedon Sep 4, 2014
Closing as Fixed.