This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Repository navigation
Remove HTML file checking in setDocInfo - #3218
Merged
Merged
Conversation
ghost
assigned
Contributor
|
The intent for the code being changed here is to prevent user from using Live Dev on non-HTML files, but that is apparently being prevented elsewhere, because I cannot find anything that is broken with this change. Looks good. Merging. |
redmunds
added a commit
that referenced
this pull request
Mar 26, 2013
Remove HTML file checking in setDocInfo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the static server exists, I believe that checking for type should be done by the
canServefunction of the provider. The StaticProvider already checks for HTML extension, so this line of code can not be executed anyway. This is a temporary fix as a longer term re-factoring is need.