Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Update 'de' locale for sprint 24, 25 - #3641

Merged
pthiess merged 11 commits into
adobe:masterfrom
ZweiSteinSoft:l10n-de
May 18, 2013
Merged

pthiess merged 11 commits into
adobe:masterfrom
ZweiSteinSoft:l10n-de

Conversation

@ZweiSteinSoft

Copy link
Copy Markdown
Contributor

Comment thread src/nls/de/strings.js Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't something like "Offene Dateien" be more appropriate?

@ghost ghost assigned pthiess May 3, 2013
Comment thread src/nls/de/strings.js Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These duplicate keys are causing the build errors on Travis CI.

@pthiess

pthiess commented May 14, 2013

Copy link
Copy Markdown
Contributor

@mynetx Thanks for reviewing and updating.I'm ok with merging this once the merge conflicts have been resolved.

Thanks,
Peter ;)

@ZweiSteinSoft

Copy link
Copy Markdown
Contributor Author

@pthiess The conflicts have already been resolved, see CI: https://travis-ci.org/adobe/brackets/builds/7098394.

Comment thread src/nls/de/strings.js

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is duplicated from line 274.

@jasonsanjose

Copy link
Copy Markdown
Member

Travis picked up one more duplicate key. See my recent comment.

@pthiess

pthiess commented May 14, 2013

Copy link
Copy Markdown
Contributor

@mynetx Please remove line 297 and I or Jason will go ahead and merge it in.

Thanks a ton again for keeping German up to date.

pthiess added a commit that referenced this pull request May 18, 2013
Update 'de' locale for sprint 24, 25
@pthiess
pthiess merged commit e89c3b8 into adobe:master May 18, 2013
@TomMalbran

Copy link
Copy Markdown
Contributor

It looks like this merge has just removed the require/text/i18n submodules.

@njx

njx commented May 18, 2013

Copy link
Copy Markdown

We should probably have docs somewhere about how to make sure submodules are properly handled during a merge. This has bitten @larz0 as well, and is becoming more common now that we have more submodules being updated more frequently.

I'm out right now, but we should have someone fix this ASAP.

@njx

njx commented May 18, 2013

Copy link
Copy Markdown

Also, we should add something to the pull request checklist to double check that there don't seem to be any spurious submodule SHA changes before merging.

@gruehle

gruehle commented May 18, 2013

Copy link
Copy Markdown
Member

Submodules fixed in #3895

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants