[JeffryBooher]

Adds fuzzy code hints to css editing:

• Create aliases for specific margin and padding types #5445

Known issues:

shape-inside: circle( <-- presents shapes again. This exists in master because we don't set the context o

[dangoor]

Do we actually need a pref for this? As long as the behavior we offer is not a cause for complaint (or something people reasonably disagree on), then I don't think a knob is needed.

[dangoor]

Initial review done.

[JeffryBooher]

@dangoor All feedback addressed ready to re-review.

[dangoor]

Hey @JeffryBooher, wow... small code change!

Unfortunately, I think a bit more code change is required, though:

1. Trying this out, the results are not ideal. Using the example from Create aliases for specific margin and padding types #5445, typing "ml" returns all sorts of stuff but margin-left is hiding way down there because the results are being sorted alphabetically. StringMatch returns too many results to be useful with an alpha sort. There's a function called basicMatchSort in StringMatch that you'd want to use to get results based on the StringMatch scoring. I'm guessing that using the match sort typing "ml" will put "margin-left" at the top.
2. There are 3 unit test failures for this extension on this branch.

[marcelgerber]

You don't need that module any more.

[JeffryBooher]

Good Point!

[JeffryBooher]

@dangoor basicStringMatch didn't do it. I'm going to have to write a custom sorter which i had thought about doing anyway.

[JeffryBooher]

It looks like jsCodeHints makes its own sort functor to callback with

penalizeUnderscoreValueCompare()

We could do something similar to that in CSS code hints

but we first want the needle to match

'ba' (background-*) matches first
and (background-attachement) is the first item in the list.

This may be difficult to do with a callback since we need the needle as well...

[dangoor]

@JeffryBooher The stringMatch function returns a value with a "matchGoodness" score. You need to hang on to that value for all of the matches and then sort on that. The penalizeUnderscoreValueCompare is just there in JS code hints to prefer public API values to private ones. JS code hints is doing what the basicMatchSort does but customized a little bit to handle the stack depth of the match and the underscores.

[JeffryBooher]

@dangoor Tests fixed and fuzzyMatching should be on par with what's expected:

"b-l-c" will get you "border-left-color" as the only option. "ml" will yield a list with "margin-left" at the top.

[dangoor]

@JeffryBooher Works great!

The code duplication seems borderline for refactoring to eliminate the duplication, but I think it's small enough that this is fine.

I'll go ahead and merge. Thanks for the nice addition!

[humphd]

One of the commits in this introduced a regression, see #11088.