Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Update Persian translation (release 0.44) - #9105

Merged
ingorichter merged 2 commits into
adobe:masterfrom
myaaghubi:my/persian-translation
Sep 25, 2014
Merged

ingorichter merged 2 commits into
adobe:masterfrom
myaaghubi:my/persian-translation

Conversation

@myaaghubi

Copy link
Copy Markdown
Contributor

No description provided.

@myaaghubi myaaghubi changed the title Update Persian translation Update Persian translation for release 0.44 Sep 20, 2014
@myaaghubi myaaghubi changed the title Update Persian translation for release 0.44 Update Persian translation (release 0.44) Sep 20, 2014
Comment thread src/nls/fa-ir/strings.js

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this placeholder looks unclosed. To properly work in the template, the {} need to be in the right order.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And there are some more in the file

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ingorichter Could this be a weird bi-di rendering thing? In the notification emails for your comments, Outlook at least renders the line above with {0} grouped all together at the end of the string.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterflynn that could be the case. Perhaps gh has issues with RTL text.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the file on my machine definitely looks okay. @mohammadyaghobi please forget my previous comments. Everything looks okay in vi.

@ingorichter

Copy link
Copy Markdown
Contributor

I have done a sanity check with google translate and it looks good to me.

@myaaghubi

Copy link
Copy Markdown
Contributor Author

Thank you both, please merge it.

ingorichter added a commit that referenced this pull request Sep 25, 2014
Update Persian translation (release 0.44)
@ingorichter
ingorichter merged commit ad55f1c into adobe:master Sep 25, 2014
@ingorichter

Copy link
Copy Markdown
Contributor

Thanks @mohammadyaghobi

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants