Skip to content

Use Java 7 relativization instead of hand-rolled code - #385

Merged
elharo merged 4 commits into
masterfrom
sdkl
Jun 5, 2025
Merged

elharo merged 4 commits into
masterfrom
sdkl

Conversation

@elharo

@elharo elharo commented May 30, 2025 •

Copy link
Copy Markdown
Contributor

There are actually two different toRelative methods used in this class, probably added at different times by different developers. This PR removes one of them.

@elharo

elharo commented May 30, 2025

Copy link
Copy Markdown
Contributor Author

Flaky CI:

Caused by: org.apache.maven.artifact.resolver.ArtifactResolutionException: The following artifacts could not be resolved: org.apache.maven.plugins:maven-plugins:xml:site_en:43 (absent): Could not transfer artifact org.apache.maven.plugins:maven-plugins:xml:site_en:43 from/to central (https://repo.maven.apache.org/maven2): status code: 403, reason phrase: Forbidden (403)

@elharo elharo changed the title Use JDK 7 relativization instead of hand-rolled code Use Java 7 relativization instead of hand-rolled code May 30, 2025
@elharo
elharo marked this pull request as ready for review May 31, 2025 10:26
@elharo

elharo commented May 31, 2025

Copy link
Copy Markdown
Contributor Author

CI is flaky and broken

@elharo
elharo requested review from michael-o and slachiewicz May 31, 2025 10:27
@elharo
elharo merged commit 75575cd into master Jun 5, 2025
@elharo
elharo deleted the sdkl branch June 5, 2025 10:35
@github-actions github-actions Bot added this to the 3.11.3 milestone Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants