Repository navigation
Use the resolver's own HTTP transport in the report plugin tests - #3414
Merged
slachiewicz merged 1 commit intoAug 8, 2026
Merged
Conversation
The test classpath carried maven-resolver-transport-wagon together with wagon-http-lightweight purely so that Resolver had some way of speaking HTTP. Resolver has shipped its own HTTP transport for years, so one dependency does what two did. wagon-http-lightweight is also marked for removal in Wagon 4.0.0, and nothing here needs a Wagon provider specifically.
slachiewicz
added
dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maven-surefire-report-plugin's test classpath carried two artifacts to give Resolver a way of speaking HTTP:Resolver has had its own HTTP transport since 1.0, so
maven-resolver-transport-httpat the same${resolverVersion}(1.9.27 here) does the same job on its own.maven-resolver-connector-basicis untouched — that is the connector, not the transport.wagon-http-lightweightis additionally marked for removal in Wagon 4.0.0, and nothing in these tests needs a Wagon provider in particular; it was only ever the thing on the other side of the wagon transport.Verified:
mvn -pl maven-surefire-report-plugin testgives 13 tests, 0 failures, both before and after.This came out of a survey of how Maven projects actually depend on Wagon. The identical pattern is being changed in apache/maven-project-info-reports-plugin#648 and apache/maven-checkstyle-plugin#681. It deliberately is not being changed in maven-doap-plugin: its tests resolve through the legacy
maven-compatWagonManager, which looks up a Wagon by protocol, so a resolver transport cannot stand in — swapping it there fails withCannot find wagon which supports the requested protocol: https.