Skip to content

Migrate legacy plugin Javadoc annotations - #3416

Merged
slachiewicz merged 1 commit into
apache:masterfrom
wilx:agent/legacy-plugin-annotations
Aug 8, 2026
Merged

slachiewicz merged 1 commit into
apache:masterfrom
wilx:agent/legacy-plugin-annotations

Conversation

@wilx

@wilx wilx commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Summary

Replace the legacy Maven Plugin Tools Javadoc tags in the SUREFIRE-946 self-destruct helper plugin with maven-plugin-annotations metadata.

The conversion preserves the selfdestruct goal name, its test default phase, and the two mojo parameters. The annotation dependency is provided-scoped and uses an explicit version because this standalone IT fixture is copied without reactor property filtering.

This does not change Surefire runtime behavior; it keeps the test helper compatible with annotation-based plugin descriptor generation as Maven Plugin Tools moves away from QDox.

Related to apache/maven-plugin-tools#718.

Validation

With Maven 3.9.16 and JDK 21:

mvn -B -V clean install -nsu -P run-its

The complete 17-module reactor passed. The Surefire946KillMainProcessInReusableForkIT regression coverage passed all 6 cases; the complete surefire-its module ran 759 tests with 0 failures and 0 errors (153 skipped).

Replace legacy Maven Plugin Tools Javadoc tags in the SUREFIRE-946 helper plugin with maven-plugin-annotations metadata. Add the provided annotation dependency.
@wilx
wilx marked this pull request as ready for review August 8, 2026 14:11
@slachiewicz
slachiewicz merged commit 37f0725 into apache:master Aug 8, 2026
14 checks passed
@github-actions github-actions Bot added this to the 3.6.0-M2 milestone Aug 8, 2026
@wilx
wilx deleted the agent/legacy-plugin-annotations branch August 8, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants