Repository navigation
[SUREFIRE-862, SUREFIRE-3178] Handle missing Failsafe summary files - #3417
Merged
Merged
Conversation
wilx
marked this pull request as ready for review
August 8, 2026 19:28
Skip configured summary files that were not created because no integration tests ran. Log each missing path at debug level and cover all-missing and mixed-summary cases. Fixes apache#862.
Let VerifyMojo report a no-tests result when failIfNoTests is enabled even if integration-test did not write a summary file. Cover the empty test class regression with unit and integration tests. Fixes apache#3178.
wilx
force-pushed
the
issue-862-failsafe-missing-summaries
branch
from
August 8, 2026 19:41
a542b1b to
aa17756
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #862.
Fixes #3178.
Summary
Failsafe 3.3.1 stopped writing a summary file when an integration-test
execution runs no tests. This is intentional, but
VerifyMojostill triedto read every path configured through
summaryFiles, causing verificationof POM modules to fail with
FileNotFoundException.The same missing summary also caused
verifyto return before the normalfailIfNoTestscheck, so an empty discovered test class incorrectly produceda successful build even with
failIfNoTests=true.This change:
failIfNoTests=true;Validation
mvn clean installwith JDK 17: passed (all 17 reactor modules).mvn -Prun-its clean installwith JDK 17: passed (760 tests,0 failures, 0 errors, 153 skipped).
VerifyMojoTestunit tests: 6 tests passed.Surefire862MissingSummaryFilesIT: 1 integration test passed.Surefire3178FailIfNoTestsIT: 1 integration test passed through therun-itsprofile.snapshot; its reported 3.3.0 failure and 3.3.1 success were also reproduced.
The JDK 8 build in this environment is blocked by the unrelated existing
ProcessCheckerTest.shouldHavePidAtBeginstart-time assertion; the same testand both complete builds pass with JDK 17.
Following this checklist to help us incorporate your
contribution quickly and easily:
mvn clean installto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean install).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.