Repository navigation
Restore the table borders lost in the APT conversion - #3424
Merged
Merged
Conversation
A Markdown pipe table renders as class="table table-striped"; the APT tables these two pages came from rendered as class="table table-bordered table-striped", so the conversion in #3422 quietly dropped the cell borders. Doxia parses a raw HTML table back into the same table it built from APT -- the class and the per-cell style survive verbatim and it still applies the alternating row classes itself -- so writing these two out as HTML restores the original rendering exactly. Verified against the pre-conversion site: examples/toolchains now matches the APT baseline on every axis compared, and the only remaining difference on surefire-api/index is the Term and Definition header cells, which were added deliberately in #3422 because a Markdown table cannot express a headerless one. history.md.vm keeps its Markdown table on purpose. It carries 24 links and 38 line breaks across nine rows and gains a row every release, so readable source is worth more there than the border. Generated-by: Claude Opus 5 (1M context)
slachiewicz
added
documentation
slachiewicz
marked this pull request as ready for review
August 10, 2026 00:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3422, which merged before this fix could be included.
The problem
A Markdown pipe table renders as
class="table table-striped". The APT tables these two pages came from rendered asclass="table table-bordered table-striped", so the conversion quietly dropped the cell borders on:maven-surefire-plugin/src/site/markdown/examples/toolchains.md.vmsurefire-api/src/site/markdown/index.mdI reported this in #3422 as a limitation of the Markdown sink that could not be controlled from the source document. That was wrong — it is true of a pipe table, but not of the source in general.
The fix
Doxia parses a raw HTML
<table>back into the same table it built from APT: the class and the per-cellstylesurvive verbatim, and it still applies the alternatingtr class="a"/"b"itself. Writing these two tables out as HTML restores the original rendering exactly.Verification
Compared against the pre-conversion site, on the same three axes used for #3422 — document title, author and date metadata plus visible text and link targets; block structure including
<pre>and<table>classes; and heading anchors:examples/toolchains.htmldrops out of all three axes entirely. It is now an exact match for the APT baseline,table-borderedandstyle="text-align: left;"and all.surefire-api/index.html's only remaining difference is the twoTerm/Definitionheader cells, which were added deliberately in Convert the remaining site documentation from APT to Markdown #3422 because a Markdown table cannot express a headerless one.What is deliberately left alone
maven-surefire-plugin/src/site/markdown/history.md.vmkeeps its Markdown table. It carries 24 links and 38 line breaks across nine rows, and it is the changelog that gains a row every release — handing maintainers hand-written HTML in the file they edit most often, to gain a border, is the wrong trade. That page keepstable table-striped.Generated-by: Claude Opus 5 (1M context)